From: Cyril Hrubis <chrubis@suse.cz>
To: Alejandro Colomar <alx@kernel.org>
Cc: David Howells <dhowells@redhat.com>, linux-man@vger.kernel.org
Subject: Re: ioctl_pipe(2): SYNOPSIS: $1
Date: Mon, 16 Dec 2024 11:23:44 +0100 [thread overview]
Message-ID: <Z1__sIy3Kyka0nrS@yuki.lan> (raw)
In-Reply-To: <20241214180423.2thsuyyfosrlyajb@devuan>
Hi!
> > The manual page ioctl_pipe(2) has this synopsis:
> >
> > int ioctl(int pipefd[1], IOC_WATCH_QUEUE_SET_SIZE, int size);
> > int ioctl(int pipefd[1], IOC_WATCH_QUEUE_SET_FILTER,
> > struct watch_notification_filter *filter);
> >
> > Which says the $1 is an array of int (the type is declared as int[1]).
> > However, this is incorrect, since the first argument is of course a
> > plain int, a single file descriptor. Would you mind revising the page?
That looks indeed wrong, I suppose that we need just 'int pipefd' there.
And looking at the kernel both pipe file descriptors seems to get the
exact same fops so it shouldn't matter on which end we call the ioctl().
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2024-12-16 10:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241214180348.pp4vrlnxqpo6cus6@devuan>
2024-12-14 18:04 ` ioctl_pipe(2): SYNOPSIS: $1 Alejandro Colomar
2024-12-16 10:23 ` Cyril Hrubis [this message]
2024-12-23 21:29 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1__sIy3Kyka0nrS@yuki.lan \
--to=chrubis@suse.cz \
--cc=alx@kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox