From: Danilo Krummrich <dakr@kernel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "Tamir Duberstein" <tamird@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>, "DJ Delorie" <dj@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Will Newton" <will.newton@linaro.org>,
"Paul Eggert" <eggert@cs.ucla.edu>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
rust-for-linux@vger.kernel.org, linux-man@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] rust: alloc: satisfy POSIX alignment requirement
Date: Tue, 11 Feb 2025 22:53:57 +0100 [thread overview]
Message-ID: <Z6vG9QlPbwfpxwdJ@pollux> (raw)
In-Reply-To: <CANiq72m8W7Ve_X0nQNQVdbBFxp7QD-iCQ7fx7hBwkT1rHfMssw@mail.gmail.com>
On Tue, Feb 11, 2025 at 10:46:14PM +0100, Miguel Ojeda wrote:
> On Tue, Feb 11, 2025 at 4:21 PM Tamir Duberstein <tamird@gmail.com> wrote:
> >
> > Drat, will do.
>
> Thanks!
>
> > Yep, I mentioned it under "Changes in v4".
>
> I meant to confirm the reasoning -- it is all good, thanks!
> (personally I would probably have dropped it in a case like this,
> since the change in comments is substantial and Danilo was waiting for
> the clarification from Alejandro etc.).
Agree with Miguel, better to drop it in such cases.
But no worries, Tamir. It was still valid in this case, which is why I did not
complain. :)
Also feel free to keep it for v5, moving to Gary's simplification.
- Danilo
next prev parent reply other threads:[~2025-02-11 21:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 14:55 [PATCH v4] rust: alloc: satisfy POSIX alignment requirement Tamir Duberstein
2025-02-11 15:18 ` Miguel Ojeda
2025-02-11 15:20 ` Tamir Duberstein
2025-02-11 21:46 ` Miguel Ojeda
2025-02-11 21:50 ` Tamir Duberstein
2025-02-11 21:53 ` Danilo Krummrich [this message]
2025-02-11 21:56 ` Tamir Duberstein
2025-02-11 16:52 ` Gary Guo
2025-02-11 17:12 ` Tamir Duberstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6vG9QlPbwfpxwdJ@pollux \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dj@redhat.com \
--cc=eblake@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox