From: Lennart Jablonka <humm@ljabl.com>
To: Alejandro Colomar <alx@kernel.org>,
"G. Branden Robinson" <g.branden.robinson@gmail.com>
Cc: linux-man@vger.kernel.org
Subject: Re: [PATCH] string_copying.7: tfix
Date: Fri, 28 Jul 2023 23:26:15 +0000 [thread overview]
Message-ID: <ZMROl_ZM80HoB9Ss@fluorine.ljabl.com> (raw)
In-Reply-To: <b6ce1d14-528f-cbe9-8117-be684526e36f@kernel.org>
>> diff --git a/man7/string_copying.7 b/man7/string_copying.7
>> index da1fc6752..04426ef77 100644
>> --- a/man7/string_copying.7
>> +++ b/man7/string_copying.7
>> @@ -280,9 +280,9 @@ instead of
>> In programs that make considerable use of strings or character sequences,
>> and need the best performance,
>> using overlapping character sequences can make a big difference.
>> -It allows holding subsequences of a larger character sequence.
>> +It allows holding sub-sequences of a larger character sequence,
>
>In this case, man-pages(7) advises to not hyphenate:
I see. I stumbled a little, “subsequences” being similar to
“subsequent.” I don’t have a strong opinion.
>> while not duplicating memory
>> -nor using time to do a copy.
>> +or using time to do a copy.
>
>Is nor incorrect here?
It’s not exactly incorrect here. Such a usage is common; who
am I to say that it’s wrong? It’s not useful to use it here,
either. The most common use of nor is a neither-nor construction:
The weather is neither good nor bad. Not good and not bad. Not
either good or bad. Admire the construction’s elegance: two
little conjunctions, forming a pair (though a pair it need not be)
to give you the anticipated meaning, clear in every word along the
way. Though that construction isn’t what’s used here.
Here, compare
while (not ((duplicating memory) or (using time to do a copy)))
to
while not duplicating memory nor using time to do a copy
which you might imagine as expanding to
while not duplicating memory and not using time to do a copy
with imagined precedence as
while ((not (duplicating memory)) and (not (using time to do a copy)))
where, thus, the word “nor” seems to be split in half. It works.
It’s correct. And yet it instills in me a strange feeling of
unorderedness.
Your mileage may vary.
>I'm not a native English speaker
Neither am I.
>and would like to understand why it is incorrect.
>> @@ -444,8 +444,8 @@ is a more useful alternative to this function.
>> .\" ----- DESCRIPTION :: Functions :: zustr2ustp(3) --------------------/
>> .TP
>> .BR zustr2ustp (3)
>> -This function copies the input character sequence
>> -contained in a null-padded wixed-width buffer,
>> +This function copies the input character sequence,
>
>I believe the below is like a parenthetical, which is why I put it
>between commas; isn't it? Although your version also looks good.
>
>> +contained in a null-padded fixed-width buffer,
>
>Ok
>
>> into a destination character sequence.
The “contained in a null-padded fixed-width buffer” indeed looks
like a parenthetical (or rather, a non-restrictive participial
clause—the “contained” is the participle), which is why it should
be between commas. You didn’t do quite that: You put a comma
after it, but not before.
This case is what I tried to explain: You set off the “into
a destination character sequence” prepositional phrase (the “into”
being the preposition) by a comma. You did not surround the
participial clause by commas. That’s what I did.
next prev parent reply other threads:[~2023-07-28 23:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 18:41 [PATCH] string_copying.7: tfix Lennart Jablonka
2023-07-28 21:31 ` Alejandro Colomar
2023-07-28 23:26 ` Lennart Jablonka [this message]
2023-07-29 11:09 ` Alejandro Colomar
2023-07-29 9:50 ` G. Branden Robinson
2023-07-29 11:17 ` Alejandro Colomar
2023-07-29 11:29 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMROl_ZM80HoB9Ss@fluorine.ljabl.com \
--to=humm@ljabl.com \
--cc=alx@kernel.org \
--cc=g.branden.robinson@gmail.com \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox