Re: [PATCH v4 3/5] smartpqi: update host attribute descriptions

Alejandro Colomar
2023-10-03T00:28:16Z

[-- Attachment #1: Type: text/plain, Size: 2234 bytes --]

Hi Don,

On Mon, Oct 02, 2023 at 02:54:02PM -0500, Don Brace wrote:
> Minor description changes for host attributes.
>
> Just some small changes to the host attribute descriptions.
> Remove the "version" sysfs entry. This entry was changed
> to two sysfs entries: driver_version and firmware_version.

Should we add a HISTORY section and document the old "version" sysfs
entry there, saying that it has been replaced by those two entries?

Thanks,
Alex

>
> Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
> Reviewed-by: Scott Teel <scott.teel@microchip.com>
> Reviewed-by: Mike McGowen <mike.mcgowen@microchip.com>
> Reviewed-by: Kevin Barnett <kevin.barnett@microchip.com>
> Signed-off-by: Don Brace <don.brace@microchip.com>
> ---
> man4/smartpqi.4 | 21 ++-------------------
> 1 file changed, 2 insertions(+), 19 deletions(-)
>
> diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
> index 34864e60755b..c51405c8b9cc 100644
> --- a/man4/smartpqi.4
> +++ b/man4/smartpqi.4
> @@ -135,29 +135,12 @@ The host
> attribute is a write-only attribute.
> Writing to this attribute will cause the driver to scan for new,
> changed, or removed devices (e.g., hot-plugged tape drives, or newly
> -configured or deleted logical drives) and notify the SCSI mid-layer of
> +configured or deleted logical volumes) and notify the SCSI mid-layer of
> any changes detected.
> Usually this action is triggered automatically by configuration
> changes, so the user should not normally have to write to this file.
> Doing so may be useful when hot-plugging devices such as tape drives or
> -entire storage boxes containing pre-configured logical drives.
> -.TP
> -.IR /sys/class/scsi_host/host * /version
> -The host
> -.I version
> -attribute is a read-only attribute.
> -This attribute contains the driver version and the controller firmware
> -version.
> -.IP
> -For example:
> -.IP
> -.in +4n
> -.EX
> -$ \c
> -.B cat /sys/class/scsi_host/host1/version
> -driver: 1.1.2\-126
> -firmware: 1.29\-112
> -.EE
> +entire storage boxes containing pre-configured logical volumes.
> .in
> .TP
> .IR /sys/class/scsi_host/host * /lockup_action
> --
> 2.42.0.296.g493f462273
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]