Re: [PATCH v6 1/6] smartpqi: add module parameter ctrl_ready_timeout

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2646 bytes --]

On Tue, Oct 03, 2023 at 02:54:34PM -0500, Don Brace wrote:
> Allow user to change the length of time that the driver
> will wait for the controller to become ready.
> 
> Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
> Reviewed-by: Scott Teel <scott.teel@microchip.com>
> Reviewed-by: Mike McGowen <mike.mcgowen@microchip.com>
> Reviewed-by: Kevin Barnett <kevin.barnett@microchip.com>
> Signed-off-by: Don Brace <don.brace@microchip.com>

Thanks.  Patch applied.  I applied the following minor formatting fix to
your patch.

Cheers,
Alex


diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
index e12d82296..a213b3b70 100644
--- a/man4/smartpqi.4
+++ b/man4/smartpqi.4
@@ -17,7 +17,7 @@ .SH SYNOPSIS
 .RB [ expose_ld_first= { 0 | 1 }]
 .RB [ hide_vsep= { 0 | 1 }]
 .RB [ disable_managed_interrupts= { 0 | 1 }]
-.RB [ ctrl_ready_timeout= { 0 | [30, 1800] }]
+.RB [ ctrl_ready_timeout= { 0 |[ 30 , 1800 ]}]
 .YS
 .SH DESCRIPTION
 .B smartpqi
@@ -112,7 +112,9 @@ .SS Boot options
 .BR ctrl_ready_timeout= { 0 | [30, 1800] }
 This option specifies the timeout in seconds for the driver to wait
 for the controller to be ready.
-The valid range is 0 or [30, 1800]. The default value is 0,
+The valid range is 0 or
+.RB [ 30 ", " 1800 ].
+The default value is 0,
 which causes the driver to use a timeout of 180 seconds.
 .SH FILES
 .SS Device nodes



> ---
>  man4/smartpqi.4 | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
> index 32f9240e37f2..e12d82296108 100644
> --- a/man4/smartpqi.4
> +++ b/man4/smartpqi.4
> @@ -17,6 +17,7 @@ smartpqi \- Microchip Smart Storage SCSI driver
>  .RB [ expose_ld_first= { 0 | 1 }]
>  .RB [ hide_vsep= { 0 | 1 }]
>  .RB [ disable_managed_interrupts= { 0 | 1 }]
> +.RB [ ctrl_ready_timeout= { 0 | [30, 1800] }]
>  .YS
>  .SH DESCRIPTION
>  .B smartpqi
> @@ -107,6 +108,12 @@ Disables driver utilization of Linux kernel managed interrupts for controllers.
>  The managed interrupts feature automatically distributes interrupts
>  to all available CPUs and assigns SMP affinity.
>  The default value is 0 (managed interrupts enabled).
> +.TP
> +.BR ctrl_ready_timeout= { 0 | [30, 1800] }
> +This option specifies the timeout in seconds for the driver to wait
> +for the controller to be ready.
> +The valid range is 0 or [30, 1800]. The default value is 0,
> +which causes the driver to use a timeout of 180 seconds.
>  .SH FILES
>  .SS Device nodes
>  Logical drives are accessed via the SCSI disk driver
> -- 
> 2.42.0.296.g493f462273
> 

-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]