Re: [PATCH 2/5] ld.so.8: Clarify LD_PROFILE in secure-execution mode

Adhemerval Zanella Netto
2023-10-18T20:47:33Z

On 18/10/23 16:19, Alejandro Colomar wrote:
> Hi Adhemerval,
>
> On Wed, Oct 18, 2023 at 02:21:01PM -0300, Adhemerval Zanella wrote:
>> Different than specified, glibc 2.2.5 does not ignore LD_PROFILE in
>
> The text being removed talks about glibc _before_ 2.2.5, that is,
> every version until 2.2.4. That doesn't match the commit message.
> Please check.

There is no different between 2.2.4 and 2.2.5, LD_PROFILE is always
accepeted for secure-execution mode, while LD_PROFILE_OUTPUT is
ignored (the default path is used ("/var/profile")).

I though it would make clear to specify the profile path only on
LD_PROFILE description, but I don't have a strong preference.

>
> Thanks,
> Alex
>
>> secure-execution mode. Instead, it uses the default LD_PROFILE_OUTPUT
>> (/var/profile) folder.
>>
>> Signed-off-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>> ---
>> man8/ld.so.8 | 15 ++++++---------
>> 1 file changed, 6 insertions(+), 9 deletions(-)
>>
>> diff --git a/man8/ld.so.8 b/man8/ld.so.8
>> index 5b5c22825..74286d583 100644
>> --- a/man8/ld.so.8
>> +++ b/man8/ld.so.8
>> @@ -664,7 +664,7 @@ Profiling output is appended to the file whose name is:
>> .IP
>> Since glibc 2.2.5,
>> .B LD_PROFILE
>> -is ignored in secure-execution mode.
>> +uses a different default path in secure-execution mode.
>> .TP
>> .BR LD_PROFILE_OUTPUT " (since glibc 2.1)"
>> Directory where
>> @@ -672,16 +672,13 @@ Directory where
>> output should be written.
>> If this variable is not defined, or is defined as an empty string,
>> then the default is
>> -.IR /var/tmp .
>> +.IR /var/tmp
>> +or
>> +.IR /var/profile
>> +in secure-execution mode.
>> .IP
>> .B LD_PROFILE_OUTPUT
>> -is ignored in secure-execution mode; instead
>> -.I /var/profile
>> -is always used.
>> -(This detail is relevant only before glibc 2.2.5,
>> -since in later glibc versions,
>> -.B LD_PROFILE
>> -is also ignored in secure-execution mode.)
>> +is ignored in secure-execution mode.
>> .TP
>> .BR LD_SHOW_AUXV " (since glibc 2.1)"
>> If this environment variable is defined (with any value),
>> --
>> 2.34.1
>>
>