Re: [PATCH 2/2] ioctl_pagemap_scan: add page for pagemap_scan IOCTL

Alejandro Colomar
2023-10-19T12:51:12Z

[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]

Hi Muhammad,

On Thu, Oct 19, 2023 at 05:31:32PM +0500, Muhammad Usama Anjum wrote:
> Hi Alex,
>
> Thank you for taking time to review. I'll fix everything and run lint
> before sending next revision.

Thanks.

[...]

> >> +.SH DESCRIPTION
> >> +This
> >> +.BR ioctl (2)
> >> +is used to get and optionally clear some specific flags from page table entries.
> >> +
> >
> > Please use an empty roff(7) request instead of a empty input line. That
> > is, use a line with just a '.', that is, s/^$/./

Another thing you can use is a comment:

.\"

This is more commonly found in other pages in this repository.

Cheers,
Alex

> >
> > $ make lint build check --debug=print
> > TROFF .tmp/man/man2/ioctl_pagemap_scan.2.cat.set
> > ! (troff -wbreak -man -Tutf8 -rLL=78n -rCHECKSTYLE=3 -ww <.tmp/man/man2/ioctl_pagemap_scan.2.cat.troff 2>&1 >.tmp/man/man2/ioctl_pagemap_scan.2.cat.set \
> > | grep -v -f './share/lint/groff/man.ignore.grep' \
> > ||:; \
> > ) \
> > | grep ^ >&2
> > an.tmac:man2/ioctl_pagemap_scan.2:25: style: blank line in input
> > ...

--
<https://www.alejandro-colomar.es/>