From: Alejandro Colomar <alx@kernel.org>
To: Max Kellermann <max.kellermann@ionos.com>
Cc: linux-man@vger.kernel.org
Subject: Re: [PATCH] man2/clone.2: clarify that CLONE_CLEAR_SIGHAND does not affect SIG_IGN
Date: Mon, 30 Oct 2023 17:21:49 +0100 [thread overview]
Message-ID: <ZT_YHozq7Pu_t9Nq@debian> (raw)
In-Reply-To: <CAKPOu+_XsNNYLvM=0KvEF1vUW4hANCey7YjZkKdhxtxJME7YeQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1762 bytes --]
Hi Max,
On Mon, Oct 30, 2023 at 02:52:48PM +0100, Max Kellermann wrote:
> On Mon, Oct 30, 2023 at 2:47 PM Alejandro Colomar <alx@kernel.org> wrote:
> > Would you mind sending an example program that proves this?
>
> If you need proof, all you need to do is look at the commit adding the
> feature (or the code comments it added which are still there):
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b612e5df4587c934bd056bf05f4a1deca4de4f75
Thanks, that also works. That commit message is very explicit in this
regard. When reviewing a patch, it helps if that kind of information is
included in the commit message (and it also helps review old patches in
the future, not just when applying it). It's covered in ./CONTRIBUTING:
- Describe how you obtained the information in your patch. For
example, was it:
- by reading (or writing) the relevant kernel or (g)libc
source code? Please provide a pointer to the following
code.
- from a commit message in the kernel or (g)libc source code
repository? Please provide a commit ID.
- by writing a test program? Send it with the patch, but
please make sure it's as simple as possible, and provide
instructions on how to use it and/or a demo run.
- from a standards document? Please name the standard, and
quote the relevant text.
- from other documentation? Please provide a pointer to that
documentation.
- from a mailing list or online forum? Please provide a URL
if possible.
Cheers,
Alex
--
<https://www.alejandro-colomar.es/>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-10-30 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 12:58 [PATCH] man2/clone.2: clarify that CLONE_CLEAR_SIGHAND does not affect SIG_IGN Max Kellermann
2023-10-30 13:47 ` Alejandro Colomar
2023-10-30 13:52 ` Max Kellermann
2023-10-30 16:21 ` Alejandro Colomar [this message]
2023-10-30 16:27 ` [PATCH v2] " Max Kellermann
2023-10-31 12:45 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZT_YHozq7Pu_t9Nq@debian \
--to=alx@kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=max.kellermann@ionos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox