Re: [PATCH v9 2/3] smartpqi: remove sysfs entry for version

Alejandro Colomar
2023-10-24T23:10:10Z

[-- Attachment #1: Type: text/plain, Size: 2082 bytes --]

Hi Don,

On Tue, Oct 24, 2023 at 05:01:52PM -0500, Don Brace wrote:
> Remove the "version" sysfs entry. This entry was changed into
> two sysfs entries: driver_version and firmware_version.
>
> Add HISTORY section.
> Enumerate old sysfs entries replaced by newer entries.
>
> Signed-off-by: Don Brace <don.brace@microchip.com>
> Suggested-by: Alejandro Colomar <alx@kernel.org>
> Signed-off-by: Don Brace <don.brace@microchip.com>
> ---
> man4/smartpqi.4 | 25 +++++++------------------
> 1 file changed, 7 insertions(+), 18 deletions(-)
>
> diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
> index ea8bd5e2d612..0cb018d01fc5 100644
> --- a/man4/smartpqi.4
> +++ b/man4/smartpqi.4
> @@ -145,24 +145,6 @@ changes, so the user should not normally have to write to this file.
> Doing so may be useful when hot-plugging devices such as tape drives or
> entire storage boxes containing pre-configured logical volumes.
> .TP
> -.IR /sys/class/scsi_host/host * /version
> -The host
> -.I version
> -attribute is a read-only attribute.
> -This attribute contains the driver version and the controller firmware
> -version.
> -.IP
> -For example:
> -.IP
> -.in +4n
> -.EX
> -$ \c
> -.B cat /sys/class/scsi_host/host1/version
> -driver: 1.1.2\-126
> -firmware: 1.29\-112
> -.EE
> -.in
> -.TP
> .IR /sys/class/scsi_host/host * /lockup_action
> The host
> .I lockup_action
> @@ -393,6 +375,13 @@ refer to the User Guide for the controller,
> which can be found by searching for the specific controller at
> .UR https://www.microchip.com/design-centers/storage
> .UE .
> +.SH HISTORY
> +.I /sys/class/scsi_host/host*/version
> +was replaced by two sysfs entries:
> +.IP
> +.I /sys/class/scsi_host/host*/driver_version
> +.IP
> +.I /sys/class/scsi_host/host*/firmware_version

Should we maybe specify when this changed? Do you think that would be
relevant to programmers?

Thanks,
Alex

> .SH SEE ALSO
> .BR cciss (4),
> .BR hpsa (4),
> --
> 2.42.0.482.g2e8e77cbac