public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: Alejandro Colomar <alx@kernel.org>
To: Bruno Haible <bruno@clisp.org>
Cc: linux-man@vger.kernel.org, alx.manpages@gmail.com
Subject: Re: [PATCH] prctl.2: Fix typo
Date: Tue, 31 Oct 2023 13:40:58 +0100	[thread overview]
Message-ID: <ZUD12kxqzd0PsT_E@debian> (raw)
In-Reply-To: <4678853.9Mp67QZiUf@nimes>

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

Hi Bruno,

On Sun, Oct 29, 2023 at 09:51:55PM +0100, Bruno Haible wrote:
> The synopsis of the prctl.2 page has:
> 
>        int prctl(int option, ...
> 
> This makes no sense, because
>   - the first argument is not optional; it is mandatory.
>   - the title of the page is "operations on a process or thread".
> 
> It is thus clear that the first argument indicates the operation to perform.
> 
> Find attached the correction.

Agree.  I've seen there are other similarly incorrect uses of the word
"option" where "operation" should have been used in the same page (but
there are some that are correctly used).  Would you mind checking the
entire page for those other replacements?

> From a373bed1d7cd571cffc5ea1a8c6377efbe8fa51c Mon Sep 17 00:00:00 2001
> From: Bruno Haible <bruno@clisp.org>
> Date: Sun, 29 Oct 2023 21:46:49 +0100
> Subject: [PATCH] prctl.2: Fix typo
> 
> ---

Please include the explanation from above in the commit message.

Thanks,
Alex

>  man2/prctl.2 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man2/prctl.2 b/man2/prctl.2
> index f72aeb700..b5be0def6 100644
> --- a/man2/prctl.2
> +++ b/man2/prctl.2
> @@ -46,7 +46,7 @@ Standard C library
>  .nf
>  .B #include <sys/prctl.h>
>  .PP
> -.BI "int prctl(int " option ", ..."
> +.BI "int prctl(int " operation ", ..."
>  .BI "          \fR/*\fP unsigned long " arg2 ", unsigned long " arg3 ,
>  .BI "          unsigned long " arg4 ", unsigned long " arg5 " \fR*/\fP );"
>  .fi
> -- 
> 2.34.1
> 


-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2023-10-31 14:06 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-29 20:51 [PATCH] prctl.2: Fix typo Bruno Haible
2023-10-31 12:40 ` Alejandro Colomar [this message]
2023-10-31 14:31   ` Stefan Puiu
2023-10-31 16:11     ` Alejandro Colomar
2023-10-31 16:19       ` enh
2023-10-31 18:40         ` Alejandro Colomar
2023-10-31 19:15           ` enh
2023-10-31 21:23             ` Alejandro Colomar
2023-11-01  0:37               ` enh
2023-11-01 10:16                 ` Alejandro Colomar
2024-03-03 12:15                   ` [PATCH 0/2] Use terms consistently in function parameter names Alejandro Colomar
2024-03-03 12:15                   ` [PATCH 1/2] man*/: epoll_*(), fcntl(), flock(), ioctl(), msgctl(), *prctl(), ptrace(), quotactl(), reboot(), semctl(), shmctl(), lockf(): Consistently use 'op' and 'operation' Alejandro Colomar
2024-03-05 18:12                     ` Alejandro Colomar
2024-03-05 19:19                       ` enh
2024-03-03 12:15                   ` [PATCH 2/2] clock_nanosleep.2, nanosleep.2: Use 'duration' rather than 'request' Alejandro Colomar
2024-03-03 12:45                     ` Bruno Haible
2024-03-03 12:55                       ` Alejandro Colomar
2024-03-03 13:02                         ` [PATCH v2 2/2] " Alejandro Colomar
2024-03-05  0:18                         ` [PATCH 2/2] clock_nanosleep.2, " enh
2024-03-05  0:34                           ` Alejandro Colomar
2024-03-05  0:56                             ` enh
2024-03-05  1:11                               ` Alejandro Colomar
2024-03-05  1:26                                 ` [PATCH v3 3/3] clock_nanosleep.2: Use 't' " Alejandro Colomar
2024-03-05 22:22                                 ` [PATCH 2/2] clock_nanosleep.2, nanosleep.2: Use 'duration' " enh
2023-10-31 17:08       ` [PATCH] prctl.2: Fix typo Bruno Haible
2023-10-31 21:20         ` Alejandro Colomar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZUD12kxqzd0PsT_E@debian \
    --to=alx@kernel.org \
    --cc=alx.manpages@gmail.com \
    --cc=bruno@clisp.org \
    --cc=linux-man@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox