Re: [PATCH 1/2] man*/: epoll_*(), fcntl(), flock(), ioctl(), msgctl(), *prctl(), ptrace(), quotactl(), reboot(), semctl(), shmctl(), lockf(): Consistently use 'op' and 'operation'

enh
2024-03-05T19:19:21Z

On Tue, Mar 5, 2024 at 10:12 AM Alejandro Colomar <alx@kernel.org> wrote:
>
> On Sun, Mar 03, 2024 at 01:15:09PM +0100, Alejandro Colomar wrote:
> > Reported-by: Bruno Haible <bruno@clisp.org>
> > Cc: Elliott Hughes <enh@google.com>
> > Cc: Stefan Puiu <stefan.puiu@gmail.com>
> > Signed-off-by: Alejandro Colomar <alx@kernel.org>
> > ---
> > man2/arch_prctl.2 | 12 +++---
> > man2/epoll_wait.2 | 4 +-
> > man2/fcntl.2 | 70 +++++++++++++++----------------
> > man2/flock.2 | 6 +--
> > man2/ioctl.2 | 30 +++++++-------
> > man2/ioctl_console.2 | 8 ++--
> > man2/ioctl_fideduperange.2 | 2 +-
> > man2/ioctl_getfsmap.2 | 6 +--
> > man2/ioctl_ns.2 | 2 +-
> > man2/ioctl_tty.2 | 10 ++---
> > man2/ioctl_userfaultfd.2 | 10 ++---
> > man2/msgctl.2 | 16 ++++----
> > man2/prctl.2 | 84 +++++++++++++++++++-------------------
> > man2/ptrace.2 | 60 +++++++++++++--------------
> > man2/quotactl.2 | 34 +++++++--------
> > man2/reboot.2 | 19 +++++----
> > man2/semctl.2 | 22 +++++-----
> > man2/shmctl.2 | 20 +++++----
> > man3/lockf.3 | 11 ++---
> > 19 files changed, 217 insertions(+), 209 deletions(-)
> >
> > diff --git a/man2/arch_prctl.2 b/man2/arch_prctl.2
> > index bbb85866c..680d36395 100644
> > --- a/man2/arch_prctl.2
> > +++ b/man2/arch_prctl.2
> > @@ -14,8 +14,8 @@ .SH SYNOPSIS
> > .BR "#include <sys/syscall.h>" " /* Definition of " SYS_* " constants */"
> > .B #include <unistd.h>
> > .P
> > -.BI "int syscall(SYS_arch_prctl, int " code ", unsigned long " addr );
> > -.BI "int syscall(SYS_arch_prctl, int " code ", unsigned long *" addr );
> > +.BI "int syscall(SYS_arch_prctl, int " op ", unsigned long " addr );
> > +.BI "int syscall(SYS_arch_prctl, int " op ", unsigned long *" addr );
>
> [...]
>
> Hi Elliott!
>
> This is already in master. Feel free to do a similar thing in bionic.
> ;)

already did :-)
https://android-review.googlesource.com/c/platform/bionic/+/2987969

> Have a lovely day!
> Alex
>
> --
> <https://www.alejandro-colomar.es/>
> Looking for a remote C programming job at the moment.