Re: [PATCH] prctl.2: Fix typo

Alejandro Colomar
2023-10-31T14:06:00Z

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

Hi Bruno,

On Sun, Oct 29, 2023 at 09:51:55PM +0100, Bruno Haible wrote:
> The synopsis of the prctl.2 page has:
>
> int prctl(int option, ...
>
> This makes no sense, because
> - the first argument is not optional; it is mandatory.
> - the title of the page is "operations on a process or thread".
>
> It is thus clear that the first argument indicates the operation to perform.
>
> Find attached the correction.

Agree. I've seen there are other similarly incorrect uses of the word
"option" where "operation" should have been used in the same page (but
there are some that are correctly used). Would you mind checking the
entire page for those other replacements?

> From a373bed1d7cd571cffc5ea1a8c6377efbe8fa51c Mon Sep 17 00:00:00 2001
> From: Bruno Haible <bruno@clisp.org>
> Date: Sun, 29 Oct 2023 21:46:49 +0100
> Subject: [PATCH] prctl.2: Fix typo
>
> ---

Please include the explanation from above in the commit message.

Thanks,
Alex

> man2/prctl.2 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man2/prctl.2 b/man2/prctl.2
> index f72aeb700..b5be0def6 100644
> --- a/man2/prctl.2
> +++ b/man2/prctl.2
> @@ -46,7 +46,7 @@ Standard C library
> .nf
> .B #include <sys/prctl.h>
> .PP
> -.BI "int prctl(int " option ", ..."
> +.BI "int prctl(int " operation ", ..."
> .BI " \fR/*\fP unsigned long " arg2 ", unsigned long " arg3 ,
> .BI " unsigned long " arg4 ", unsigned long " arg5 " \fR*/\fP );"
> .fi
> --
> 2.34.1
>

--
<https://www.alejandro-colomar.es/>