Re: [PATCH] prctl.2: Fix typo

Alejandro Colomar
2023-11-01T10:16:52Z

[-- Attachment #1: Type: text/plain, Size: 1950 bytes --]

On Tue, Oct 31, 2023 at 05:37:03PM -0700, enh wrote:
> fwiw, here's the full list of "cmd"s, "request"s, "op"s, and "option"s
> (manually edited to remove the legit "option"s like getsockopt()):

Thanks! This'll be very helpful.

>
> ~/aosp-main-with-phones/bionic/libc/include$ egrep -r
> '__(cmd|option|request|op)\b' | sort
> bits/fcntl.h:int fcntl(int __fd, int __cmd, ...);
> bits/ioctl.h:int ioctl(int __fd, int __request, ...);
> bits/lockf.h:int lockf(int __fd, int __cmd, off_t __length)
> __RENAME_IF_FILE_OFFSET64(lockf64) __INTRODUCED_IN(24);
> sys/epoll.h:int epoll_ctl(int __epoll_fd, int __op, int __fd, struct
> epoll_event* __BIONIC_COMPLICATED_NULLNESS __event);
> sys/file.h:int flock(int __fd, int __op);
> syslog.h:void openlog(const char* _Nullable __prefix, int __option,
> int __facility);
> sys/msg.h:int msgctl(int __msg_id, int __cmd, struct msqid_ds*
> _Nullable __buf) __INTRODUCED_IN(26);
> sys/prctl.h:int prctl(int __option, ...);
> sys/ptrace.h:long ptrace(int __request, ...);
> sys/quota.h:int quotactl(int __cmd, const char* _Nullable __special,
> int __id, char* __BIONIC_COMPLICATED_NULLNESS __addr)
> __INTRODUCED_IN(26);
> sys/reboot.h:int reboot(int __cmd);
> sys/sem.h:int semctl(int __sem_id, int __sem_num, int __cmd, ...)
> __INTRODUCED_IN(26);
> sys/shm.h:int shmctl(int __shm_id, int __cmd, struct shmid_ds*
> _Nullable __buf) __INTRODUCED_IN(26);
> time.h:int clock_nanosleep(clockid_t __clock, int __flags, const
> struct timespec* _Nonnull __request, struct timespec* _Nullable
> __remainder);
> time.h:int nanosleep(const struct timespec* _Nonnull __request, struct
> timespec* _Nullable __remainder);
> ~/aosp-main-with-phones/bionic/libc/include$
>
> (i'll change the <time.h> *sleep()s to use __duration instead:
> https://android-review.googlesource.com/c/platform/bionic/+/2813844)

LGTM.

Cheers,
Alex

--
<https://www.alejandro-colomar.es/>