Re: Issue in man page getdents.2

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 987 bytes --]

Hi Helge,

On Wed, Nov 01, 2023 at 02:02:10PM +0000, Helge Kreutzmann wrote:
> Without further ado, the following was found:
> 
> Issue:    Zero padding byte →  null padding byte?
> 
> msgid ""
> "struct linux_dirent {\n"
> "    unsigned long  d_ino;     /* Inode number */\n"
> "    unsigned long  d_off;     /* Offset to next I<linux_dirent> */\n"
> "    unsigned short d_reclen;  /* Length of this I<linux_dirent> */\n"
> "    char           d_name[];  /* Filename (null-terminated) */\n"
> "                      /* length is actually (d_reclen - 2 -\n"
> "                         offsetof(struct linux_dirent, d_name)) */\n"
> "    /*\n"
> "    char           pad;       // Zero padding byte\n"

Both seem good to me.  Why not zero?

Cheers,
Alex

> "    char           d_type;    // File type (only since Linux\n"
> "                              // 2.6.4); offset is (d_reclen - 1)\n"
> "    */\n"
> "}\n"

-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]