Re: [PATCH 1/2] swapon.2: Adjust decreased value under CONFIG_MIGRATION

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1578 bytes --]

Hi Yang,

On Mon, Dec 04, 2023 at 07:24:30AM -0500, Yang Xu wrote:
> After kernel 5.19[1], the limit is decreased by 3.
> 
> [1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/include/linux/swap.h?id=6c287605f
> 
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
>  man2/swapon.2 | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/man2/swapon.2 b/man2/swapon.2
> index c0e61cbc6..ee270cea1 100644
> --- a/man2/swapon.2
> +++ b/man2/swapon.2
> @@ -164,7 +164,8 @@ Before Linux 2.4.10,
>  .B MAX_SWAPFILES
>  has the value 8;
>  since Linux 2.4.10, it has the value 32.
> -Since Linux 2.6.18, the limit is decreased by 2 (thus: 30)
> +Since Linux 2.6.18, the limit is decreased by 2 (Since Linux 5.19.0,
> +the limit is decreased by 3)
>  if the kernel is built with the
>  .B CONFIG_MIGRATION
>  option
> @@ -172,6 +173,7 @@ option
>  .BR mbind (2)
>  and
>  .BR migrate_pages (2)).
> +

There should be no blank lines in man(7) source.  That would trigger a
warning.  See man-pages(7):

   Formatting conventions (general)
     Paragraphs  should  be separated by suitable markers (usually ei‐
     ther .P or .IP).  Do not separate paragraphs using  blank  lines,
     as this results in poor rendering in some output formats (such as
     PostScript and PDF).

Thanks,
Alex

>  Since Linux 2.6.32, the limit is further decreased by 1
>  if the kernel is built with the
>  .B CONFIG_MEMORY_FAILURE
> -- 
> 2.27.0
> 
> 

-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]