* [PATCH] ioctl_console: Document new CAP_SYS_ADMIN restrictions (since Linux 6.7)
@ 2023-12-01 12:26 Günther Noack
2023-12-01 12:56 ` Alejandro Colomar
2023-12-21 14:42 ` Alejandro Colomar
0 siblings, 2 replies; 6+ messages in thread
From: Günther Noack @ 2023-12-01 12:26 UTC (permalink / raw)
To: Alejandro Colomar
Cc: linux-man, Günther Noack, Hanno Böck,
Greg Kroah-Hartman
Since Linux commit 8d1b43f6a6df7bce ("tty: Restrict access to TIOCLINUX'
copy-and-paste subcommands"), the TIOCL_SETSEL, TIOCL_PASTESEL and
TIOCL_SELLOADLUT subcommands require CAP_SYS_ADMIN.
Cc: Hanno Böck <hanno@hboeck.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Günther Noack <gnoack@google.com>
---
man2/ioctl_console.2 | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/man2/ioctl_console.2 b/man2/ioctl_console.2
index 684b4d013..abc50b786 100644
--- a/man2/ioctl_console.2
+++ b/man2/ioctl_console.2
@@ -715,12 +715,20 @@ is 0 for character-by-character selection,
or 2 for line-by-line selection.
The indicated screen characters are highlighted and saved
in a kernel buffer.
+.IP
+Since Linux 6.7, using this subcode requires the
+.B CAP_SYS_ADMIN
+capability.
.TP
.BR TIOCLINUX ", " subcode = TIOCL_PASTESEL
Paste selection.
The characters in the selection buffer are
written to
.IR fd .
+.IP
+Since Linux 6.7, using this subcode requires the
+.B CAP_SYS_ADMIN
+capability.
.TP
.BR TIOCLINUX ", " subcode = TIOCL_UNBLANKSCREEN
Unblank the screen.
@@ -729,6 +737,10 @@ Unblank the screen.
Sets contents of a 256-bit look up table defining characters in a "word",
for word-by-word selection.
(Since Linux 1.1.32.)
+.IP
+Since Linux 6.7, using this subcode requires the
+.B CAP_SYS_ADMIN
+capability.
.TP
.BR TIOCLINUX ", " subcode = TIOCL_GETSHIFTSTATE
.I argp
--
2.43.0.rc2.451.g8631bc7472-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ioctl_console: Document new CAP_SYS_ADMIN restrictions (since Linux 6.7)
2023-12-01 12:26 [PATCH] ioctl_console: Document new CAP_SYS_ADMIN restrictions (since Linux 6.7) Günther Noack
@ 2023-12-01 12:56 ` Alejandro Colomar
2023-12-01 23:14 ` Greg Kroah-Hartman
2023-12-21 14:42 ` Alejandro Colomar
1 sibling, 1 reply; 6+ messages in thread
From: Alejandro Colomar @ 2023-12-01 12:56 UTC (permalink / raw)
To: Günther Noack
Cc: Alejandro Colomar, linux-man, Hanno Böck, Greg Kroah-Hartman
[-- Attachment #1: Type: text/plain, Size: 1840 bytes --]
Hi Günther, Greg,
On Fri, Dec 01, 2023 at 01:26:45PM +0100, Günther Noack wrote:
> Since Linux commit 8d1b43f6a6df7bce ("tty: Restrict access to TIOCLINUX'
> copy-and-paste subcommands"), the TIOCL_SETSEL, TIOCL_PASTESEL and
> TIOCL_SELLOADLUT subcommands require CAP_SYS_ADMIN.
>
> Cc: Hanno Böck <hanno@hboeck.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Günther Noack <gnoack@google.com>
> ---
> man2/ioctl_console.2 | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/man2/ioctl_console.2 b/man2/ioctl_console.2
> index 684b4d013..abc50b786 100644
> --- a/man2/ioctl_console.2
> +++ b/man2/ioctl_console.2
> @@ -715,12 +715,20 @@ is 0 for character-by-character selection,
> or 2 for line-by-line selection.
> The indicated screen characters are highlighted and saved
> in a kernel buffer.
> +.IP
> +Since Linux 6.7, using this subcode requires the
Are these requirements expected to be backported to stable kernels?
Cheers,
Alex
> +.B CAP_SYS_ADMIN
> +capability.
> .TP
> .BR TIOCLINUX ", " subcode = TIOCL_PASTESEL
> Paste selection.
> The characters in the selection buffer are
> written to
> .IR fd .
> +.IP
> +Since Linux 6.7, using this subcode requires the
> +.B CAP_SYS_ADMIN
> +capability.
> .TP
> .BR TIOCLINUX ", " subcode = TIOCL_UNBLANKSCREEN
> Unblank the screen.
> @@ -729,6 +737,10 @@ Unblank the screen.
> Sets contents of a 256-bit look up table defining characters in a "word",
> for word-by-word selection.
> (Since Linux 1.1.32.)
> +.IP
> +Since Linux 6.7, using this subcode requires the
> +.B CAP_SYS_ADMIN
> +capability.
> .TP
> .BR TIOCLINUX ", " subcode = TIOCL_GETSHIFTSTATE
> .I argp
> --
> 2.43.0.rc2.451.g8631bc7472-goog
>
--
<https://www.alejandro-colomar.es/>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ioctl_console: Document new CAP_SYS_ADMIN restrictions (since Linux 6.7)
2023-12-01 12:56 ` Alejandro Colomar
@ 2023-12-01 23:14 ` Greg Kroah-Hartman
2023-12-02 1:08 ` Alejandro Colomar
2023-12-05 6:20 ` Günther Noack
0 siblings, 2 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2023-12-01 23:14 UTC (permalink / raw)
To: Alejandro Colomar
Cc: Günther Noack, Alejandro Colomar, linux-man, Hanno Böck
On Fri, Dec 01, 2023 at 01:56:41PM +0100, Alejandro Colomar wrote:
> Hi Günther, Greg,
>
> On Fri, Dec 01, 2023 at 01:26:45PM +0100, Günther Noack wrote:
> > Since Linux commit 8d1b43f6a6df7bce ("tty: Restrict access to TIOCLINUX'
> > copy-and-paste subcommands"), the TIOCL_SETSEL, TIOCL_PASTESEL and
> > TIOCL_SELLOADLUT subcommands require CAP_SYS_ADMIN.
> >
> > Cc: Hanno Böck <hanno@hboeck.de>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Günther Noack <gnoack@google.com>
> > ---
> > man2/ioctl_console.2 | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/man2/ioctl_console.2 b/man2/ioctl_console.2
> > index 684b4d013..abc50b786 100644
> > --- a/man2/ioctl_console.2
> > +++ b/man2/ioctl_console.2
> > @@ -715,12 +715,20 @@ is 0 for character-by-character selection,
> > or 2 for line-by-line selection.
> > The indicated screen characters are highlighted and saved
> > in a kernel buffer.
> > +.IP
> > +Since Linux 6.7, using this subcode requires the
>
> Are these requirements expected to be backported to stable kernels?
I don't think so, do you think they should be?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ioctl_console: Document new CAP_SYS_ADMIN restrictions (since Linux 6.7)
2023-12-01 23:14 ` Greg Kroah-Hartman
@ 2023-12-02 1:08 ` Alejandro Colomar
2023-12-05 6:20 ` Günther Noack
1 sibling, 0 replies; 6+ messages in thread
From: Alejandro Colomar @ 2023-12-02 1:08 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Günther Noack, Alejandro Colomar, linux-man, Hanno Böck
[-- Attachment #1: Type: text/plain, Size: 355 bytes --]
Hi Greg,
On Sat, Dec 02, 2023 at 12:14:06AM +0100, Greg Kroah-Hartman wrote:
> > Are these requirements expected to be backported to stable kernels?
>
> I don't think so, do you think they should be?
I was asking just out of curiosity. Unless someone else speaks up,
probably not.
Cheers,
Alex
--
<https://www.alejandro-colomar.es/>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ioctl_console: Document new CAP_SYS_ADMIN restrictions (since Linux 6.7)
2023-12-01 23:14 ` Greg Kroah-Hartman
2023-12-02 1:08 ` Alejandro Colomar
@ 2023-12-05 6:20 ` Günther Noack
1 sibling, 0 replies; 6+ messages in thread
From: Günther Noack @ 2023-12-05 6:20 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Alejandro Colomar, Alejandro Colomar, linux-man, Hanno Böck
Hello!
On Sat, Dec 02, 2023 at 12:14:06AM +0100, Greg Kroah-Hartman wrote:
> On Fri, Dec 01, 2023 at 01:56:41PM +0100, Alejandro Colomar wrote:
> > On Fri, Dec 01, 2023 at 01:26:45PM +0100, Günther Noack wrote:
> > > Since Linux commit 8d1b43f6a6df7bce ("tty: Restrict access to TIOCLINUX'
> > > copy-and-paste subcommands"), the TIOCL_SETSEL, TIOCL_PASTESEL and
> > > TIOCL_SELLOADLUT subcommands require CAP_SYS_ADMIN.
> > >
> > > Cc: Hanno Böck <hanno@hboeck.de>
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Signed-off-by: Günther Noack <gnoack@google.com>
> > > ---
> > > man2/ioctl_console.2 | 12 ++++++++++++
> > > 1 file changed, 12 insertions(+)
> > >
> > > diff --git a/man2/ioctl_console.2 b/man2/ioctl_console.2
> > > index 684b4d013..abc50b786 100644
> > > --- a/man2/ioctl_console.2
> > > +++ b/man2/ioctl_console.2
> > > @@ -715,12 +715,20 @@ is 0 for character-by-character selection,
> > > or 2 for line-by-line selection.
> > > The indicated screen characters are highlighted and saved
> > > in a kernel buffer.
> > > +.IP
> > > +Since Linux 6.7, using this subcode requires the
> >
> > Are these requirements expected to be backported to stable kernels?
>
> I don't think so, do you think they should be?
Agreed, I think they don't need immediate backports either.
—Günther
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ioctl_console: Document new CAP_SYS_ADMIN restrictions (since Linux 6.7)
2023-12-01 12:26 [PATCH] ioctl_console: Document new CAP_SYS_ADMIN restrictions (since Linux 6.7) Günther Noack
2023-12-01 12:56 ` Alejandro Colomar
@ 2023-12-21 14:42 ` Alejandro Colomar
1 sibling, 0 replies; 6+ messages in thread
From: Alejandro Colomar @ 2023-12-21 14:42 UTC (permalink / raw)
To: Günther Noack; +Cc: linux-man, Hanno Böck, Greg Kroah-Hartman
[-- Attachment #1: Type: text/plain, Size: 2126 bytes --]
Hi Günther,
> Cc: Alejandro Colomar <alx.manpages@gmail.com>
I'm deprecating my gmail address; please use <alx@kernel.org>.
On Fri, Dec 01, 2023 at 01:26:45PM +0100, Günther Noack wrote:
> Since Linux commit 8d1b43f6a6df7bce ("tty: Restrict access to TIOCLINUX'
> copy-and-paste subcommands"), the TIOCL_SETSEL, TIOCL_PASTESEL and
> TIOCL_SELLOADLUT subcommands require CAP_SYS_ADMIN.
>
> Cc: Hanno Böck <hanno@hboeck.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Günther Noack <gnoack@google.com>
> ---
Patch applied; sorry for the delay. :)
<https://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/?h=contrib&id=846876d13a446836ca19ba1f619515a2cd992217>
Have a lovely day,
Alex
> man2/ioctl_console.2 | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/man2/ioctl_console.2 b/man2/ioctl_console.2
> index 684b4d013..abc50b786 100644
> --- a/man2/ioctl_console.2
> +++ b/man2/ioctl_console.2
> @@ -715,12 +715,20 @@ is 0 for character-by-character selection,
> or 2 for line-by-line selection.
> The indicated screen characters are highlighted and saved
> in a kernel buffer.
> +.IP
> +Since Linux 6.7, using this subcode requires the
> +.B CAP_SYS_ADMIN
> +capability.
> .TP
> .BR TIOCLINUX ", " subcode = TIOCL_PASTESEL
> Paste selection.
> The characters in the selection buffer are
> written to
> .IR fd .
> +.IP
> +Since Linux 6.7, using this subcode requires the
> +.B CAP_SYS_ADMIN
> +capability.
> .TP
> .BR TIOCLINUX ", " subcode = TIOCL_UNBLANKSCREEN
> Unblank the screen.
> @@ -729,6 +737,10 @@ Unblank the screen.
> Sets contents of a 256-bit look up table defining characters in a "word",
> for word-by-word selection.
> (Since Linux 1.1.32.)
> +.IP
> +Since Linux 6.7, using this subcode requires the
> +.B CAP_SYS_ADMIN
> +capability.
> .TP
> .BR TIOCLINUX ", " subcode = TIOCL_GETSHIFTSTATE
> .I argp
> --
> 2.43.0.rc2.451.g8631bc7472-goog
>
--
<https://www.alejandro-colomar.es/>
Looking for a remote C programming job at the moment.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-12-21 14:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-01 12:26 [PATCH] ioctl_console: Document new CAP_SYS_ADMIN restrictions (since Linux 6.7) Günther Noack
2023-12-01 12:56 ` Alejandro Colomar
2023-12-01 23:14 ` Greg Kroah-Hartman
2023-12-02 1:08 ` Alejandro Colomar
2023-12-05 6:20 ` Günther Noack
2023-12-21 14:42 ` Alejandro Colomar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox