Re: [PATCH v2 1/2] swapon.2: Adjust decreased value under CONFIG_MIGRATION

Yang Xu (Fujitsu)
2023-12-19T02:15:50Z

Hi Alex,

> On Fri, Dec 15, 2023 at 12:13:30PM +0100, Alejandro Colomar wrote:
>> Hi Yang,
>>
>> On Tue, Dec 05, 2023 at 01:30:16AM -0500, Yang Xu wrote:
>>> After kernel 5.19[1], the limit is decreased by 3.
>>>
>>> [1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/include/linux/swap.h?id=6c287605f
>>>
>>> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
>>
>> I've applied the patch, with some modifications:
>> <https://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/?h=contrib&id=5da8280ed6eefb3d70f86281579c4afae89230b1>
>
> Oops, my modification was wrong. I've amended that. Here are the two
> patches now:
>
> <https://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/?h=contrib&id=90ba8cf3ab2536bdc138986c4581c62a3c0b60d4>
> <https://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/?h=contrib&id=9e160cf3fd27181a72ec2fb628f64e971510f9f3>
>

Thanks for your work.

Best Regards
Yang Xu

>>
>> Cheers,
>> Alex
>>
>>> ---
>>> man2/swapon.2 | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/man2/swapon.2 b/man2/swapon.2
>>> index c0e61cbc6..2bc477d18 100644
>>> --- a/man2/swapon.2
>>> +++ b/man2/swapon.2
>>> @@ -164,7 +164,8 @@ Before Linux 2.4.10,
>>> .B MAX_SWAPFILES
>>> has the value 8;
>>> since Linux 2.4.10, it has the value 32.
>>> -Since Linux 2.6.18, the limit is decreased by 2 (thus: 30)
>>> +Since Linux 2.6.18, the limit is decreased by 2 (Since Linux 5.19.0,
>>> +the limit is decreased by 3)
>>> if the kernel is built with the
>>> .B CONFIG_MIGRATION
>>> option
>>> --
>>> 2.27.0
>>>
>>>
>>
>> --
>> <https://www.alejandro-colomar.es/>
>> Looking for a remote C programming job at the moment.
>
>
>