[Bug 218018] New: dl_iterate_phdr should mention Elf64_Phdr (in addition to Elf32_Phdr).

[Bug 218018] New: dl_iterate_phdr should mention Elf64_Phdr (in addition to Elf32_Phdr).

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218018

            Bug ID: 218018
           Summary: dl_iterate_phdr should mention Elf64_Phdr (in addition
                    to Elf32_Phdr).
           Product: Documentation
           Version: unspecified
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: man-pages
          Assignee: documentation_man-pages@kernel-bugs.osdl.org
          Reporter: ppluzhnikov@google.com
        Regression: No

dl_iterate_phdr should mention Elf64_Phdr (in addition to Elf32_Phdr).
Currently the man page says:

These program headers are structures of the following form:
  typedef { ... } Elf32_Phdr;

which is obviously wrong for 64-bit binaries.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218018] dl_iterate_phdr should mention Elf64_Phdr (in addition to Elf32_Phdr).

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218018

Rajesh (r.pandian@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |r.pandian@gmail.com

--- Comment #1 from Rajesh (r.pandian@gmail.com) ---
(In reply to Paul Pluzhnikov from comment #0)
> dl_iterate_phdr should mention Elf64_Phdr (in addition to Elf32_Phdr).
> Currently the man page says:
> 
> These program headers are structures of the following form:
>   typedef { ... } Elf32_Phdr;
> 
> which is obviously wrong for 64-bit binaries.

Hello Paul,

Do you think the following would be helpful.

Replacing "These program headers are structures of the following form:" with
the following

The ELF program header is described by the type Elf32_Phdr or Elf64_Phdr
depending on the architecture. Following is an example of 32 bit architecture.
Refer to elf (man elf) for more information on 64 bit architecture.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218018] dl_iterate_phdr should mention Elf64_Phdr (in addition to Elf32_Phdr).

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218018

--- Comment #2 from Paul Pluzhnikov (ppluzhnikov@google.com) ---
(In reply to Rajesh from comment #1)

> Do you think the following would be helpful.

Sure.

> Replacing "These program headers are structures of the following form:" with
> the following
> 
> The ELF program header is described by the type Elf32_Phdr or Elf64_Phdr
> depending on the architecture. Following is an example of 32 bit
> architecture. Refer to elf (man elf) for more information on 64 bit
> architecture.

I suggest deleting the last 4 words, i.e.

  Refer to elf (man elf) for more information.

since "man elf" describes both Elf{32,64}_Phdr in a bit more detail.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

Re: [Bug 218018] dl_iterate_phdr should mention Elf64_Phdr (in addition to Elf32_Phdr).

[Alejandro Colomar]

On Wed, Dec 27, 2023 at 04:47:48PM +0000, bugzilla-daemon@kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=218018
> 
> --- Comment #2 from Paul Pluzhnikov (ppluzhnikov@google.com) ---
> (In reply to Rajesh from comment #1)
> 
> > Do you think the following would be helpful.
> 
> Sure.
> 
> > Replacing "These program headers are structures of the following form:" with
> > the following
> > 
> > The ELF program header is described by the type Elf32_Phdr or Elf64_Phdr
> > depending on the architecture. Following is an example of 32 bit
> > architecture. Refer to elf (man elf) for more information on 64 bit
> > architecture.
> 
> I suggest deleting the last 4 words, i.e.
> 
>   Refer to elf (man elf) for more information.
> 
> since "man elf" describes both Elf{32,64}_Phdr in a bit more detail.

I suggest creating link pages Elf32_Phdr(3type) and Elf64_Phdr(3type)
both of which link to elf(5).

> 
> -- 
> You may reply to this email to add a comment.
> 
> You are receiving this mail because:
> You are watching the assignee of the bug.

-- 
<https://www.alejandro-colomar.es/>
Looking for a remote C programming job at the moment.

[Bug 218018] dl_iterate_phdr should mention Elf64_Phdr (in addition to Elf32_Phdr).

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218018

--- Comment #3 from Rajesh (r.pandian@gmail.com) ---
Great.I have submitted the patch. If they approve it will be merged. Cheers
Paul.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218018] dl_iterate_phdr should mention Elf64_Phdr (in addition to Elf32_Phdr).

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218018

--- Comment #4 from Alejandro Colomar (alx@kernel.org) ---
On Wed, Dec 27, 2023 at 04:47:48PM +0000, bugzilla-daemon@kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=218018
> 
> --- Comment #2 from Paul Pluzhnikov (ppluzhnikov@google.com) ---
> (In reply to Rajesh from comment #1)
> 
> > Do you think the following would be helpful.
> 
> Sure.
> 
> > Replacing "These program headers are structures of the following form:"
> with
> > the following
> > 
> > The ELF program header is described by the type Elf32_Phdr or Elf64_Phdr
> > depending on the architecture. Following is an example of 32 bit
> > architecture. Refer to elf (man elf) for more information on 64 bit
> > architecture.
> 
> I suggest deleting the last 4 words, i.e.
> 
>   Refer to elf (man elf) for more information.
> 
> since "man elf" describes both Elf{32,64}_Phdr in a bit more detail.

I suggest creating link pages Elf32_Phdr(3type) and Elf64_Phdr(3type)
both of which link to elf(5).

> 
> -- 
> You may reply to this email to add a comment.
> 
> You are receiving this mail because:
> You are watching the assignee of the bug.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.