Re: [PATCH] bugzilla_218018

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1866 bytes --]

Hi Rajesh,

On Fri, Dec 29, 2023 at 08:49:07AM +0530, rajesh wrote:
> Thanks for the feedback.  Have sent it with the subject  [PATCH]
> bugzilla_218018_v1

In general, I prefer if versions of patches are sent as replies to the
same mail thread, so I have it more organized in the mailbox.  It's not
a big deal, though.

Regarding the subject, the first patch you send is assumed to be v1, so
it's usual to call following ones v2 (v3, ...).  Not a big deal here
either, but take it into account for next time.  Also,
git-format-patch(1) will do the right thing for you if you pass '-v1' or
'-v2' (or '-vFOO', FWIW) to it.

Cheers,
Alex

> 
> On Fri, 29 Dec 2023 at 04:13, Tom Schwindl <schwindl@posteo.de> wrote:
> >
> > Hi,
> >
> > On Thu, Dec 28, 2023 at 09:26:01PM +0530, Rajesh Pandian wrote:
> > > ---
> > >  man3/dl_iterate_phdr.3 | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/man3/dl_iterate_phdr.3 b/man3/dl_iterate_phdr.3
> > > index 0a8beb3ae..f47fdd502 100644
> > > --- a/man3/dl_iterate_phdr.3
> > > +++ b/man3/dl_iterate_phdr.3
> > > @@ -129,7 +129,9 @@ The
> > >  .I dlpi_phnum
> > >  field indicates the size of this array.
> > >  .P
> > > -These program headers are structures of the following form:
> > > +The ELF program header is described by the type Elf32_Phdr
> > > +or Elf64_Phdr depending on the architecture.
> > > +Following is an example of 32 bit architecture:
> >
> > I'd slightly change the last sentence to
> >
> >   The following is an example of the 32-bit architecture
> >
> > since that sounds a bit nicer IMO.
> >
> > >  .P
> > >  .in +4n
> > >  .EX
> > > --
> > > 2.39.2
> > >
> > >
> >
> > --
> > Kind Regards,
> > Tom Schwindl

-- 
<https://www.alejandro-colomar.es/>
Looking for a remote C programming job at the moment.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]