[PATCH] bugzilla_218018_v1

[PATCH] bugzilla_218018_v1

[Rajesh Pandian]

---
 man3/dl_iterate_phdr.3 | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/man3/dl_iterate_phdr.3 b/man3/dl_iterate_phdr.3
index 0a8beb3ae..1355c5bcc 100644
--- a/man3/dl_iterate_phdr.3
+++ b/man3/dl_iterate_phdr.3
@@ -129,7 +129,9 @@ The
 .I dlpi_phnum
 field indicates the size of this array.
 .P
-These program headers are structures of the following form:
+The ELF program header is described by the type Elf32_Phdr 
+or Elf64_Phdr depending on the architecture.
+The following is an example of the 32-bit architecture:
 .P
 .in +4n
 .EX
-- 
2.39.2

Re: [PATCH] bugzilla_218018_v1

[Stefan Puiu]

Hi Rajesh,

2 small nits below.

On Fri, Dec 29, 2023 at 5:19 AM Rajesh Pandian <r.pandian@gmail.com> wrote:
>
> ---
>  man3/dl_iterate_phdr.3 | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/man3/dl_iterate_phdr.3 b/man3/dl_iterate_phdr.3
> index 0a8beb3ae..1355c5bcc 100644
> --- a/man3/dl_iterate_phdr.3
> +++ b/man3/dl_iterate_phdr.3
> @@ -129,7 +129,9 @@ The
>  .I dlpi_phnum
>  field indicates the size of this array.
>  .P
> -These program headers are structures of the following form:
> +The ELF program header is described by the type Elf32_Phdr
> +or Elf64_Phdr depending on the architecture.

I think "is described by the Elf32_Phdr or Elf64_Phdr type,
depending..." sounds better here.

> +The following is an example of the 32-bit architecture:

How about "The following layout applies to 32-bit architectures:"?

Thanks,
Stefan.

>  .P
>  .in +4n
>  .EX
> --
> 2.39.2
>
>

Re: [PATCH] bugzilla_218018_v1

[rajesh]

Thanks for the feedback. Sounds good. I'll send a patch later.

On Fri, 29 Dec 2023 at 18:44, Stefan Puiu <stefan.puiu@gmail.com> wrote:
>
> Hi Rajesh,
>
> 2 small nits below.
>
> On Fri, Dec 29, 2023 at 5:19 AM Rajesh Pandian <r.pandian@gmail.com> wrote:
> >
> > ---
> >  man3/dl_iterate_phdr.3 | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/man3/dl_iterate_phdr.3 b/man3/dl_iterate_phdr.3
> > index 0a8beb3ae..1355c5bcc 100644
> > --- a/man3/dl_iterate_phdr.3
> > +++ b/man3/dl_iterate_phdr.3
> > @@ -129,7 +129,9 @@ The
> >  .I dlpi_phnum
> >  field indicates the size of this array.
> >  .P
> > -These program headers are structures of the following form:
> > +The ELF program header is described by the type Elf32_Phdr
> > +or Elf64_Phdr depending on the architecture.
>
> I think "is described by the Elf32_Phdr or Elf64_Phdr type,
> depending..." sounds better here.
>
> > +The following is an example of the 32-bit architecture:
>
> How about "The following layout applies to 32-bit architectures:"?
>
> Thanks,
> Stefan.
>
> >  .P
> >  .in +4n
> >  .EX
> > --
> > 2.39.2
> >
> >

Re: [PATCH] bugzilla_218018_v1

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

Hi Stefan,

On Fri, Dec 29, 2023 at 03:14:15PM +0200, Stefan Puiu wrote:
> I think "is described by the Elf32_Phdr or Elf64_Phdr type,
> depending..." sounds better here.

+1

> > +The following is an example of the 32-bit architecture:
> 
> How about "The following layout applies to 32-bit architectures:"?

+1

Have a lovely year,
Alex

-- 
<https://www.alejandro-colomar.es/>
Looking for a remote C programming job at the moment.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]