Re: patch - fixing sample program in unix.7

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1719 bytes --]

Hi Lili,

> Subject: Re: patch - fixing sample program in unix.7

On Sun, Mar 03, 2024 at 08:27:17PM +0100, Lili Püspök wrote:
> diff --git a/man7/unix.7 b/man7/unix.7

Please add some commit message.  I don't understand what this patch
does.  How is it broken, and how does it fix it?

> index cb1dcae45..7fb41af99 100644
> --- a/man7/unix.7
> +++ b/man7/unix.7
> @@ -1057,7 +1057,7 @@ main(int argc, char *argv[])
> \&
>             if (!strncmp(buffer, "DOWN", sizeof(buffer))) {
>                 down_flag = 1;
> -                break;
> +                continue;

DOWN is used to stop the server.  How would 'continue' help?


	$ MANWIDTH=66 man unix | grep -C2 DOWN
	     tegers.  The client prints the sum and exits.   The  server
	     waits  for the next client to connect.  To stop the server,
	     the client is called with the command‐line argument "DOWN".

	     The following output was recorded while running the  server
	     in the background and repeatedly executing the client.  Ex‐
	     ecution  of  the  server  program ends when it receives the
	     "DOWN" command.

	   Example output
	--
		 $ ./client 11 -5
		 Result = 6
		 $ ./client DOWN
		 Result = 0
		 [1]+  Done                    ./server
	--
			 /* Handle commands. */

			 if (!strncmp(buffer, "DOWN", sizeof(buffer))) {
			     down_flag = 1;
			     break;
	--
		     close(data_socket);

		     /* Quit on DOWN command. */

		     if (down_flag) {

Have a lovely day,
Alex


>             }
> \&
>             if (!strncmp(buffer, "END", sizeof(buffer))) {
> 

-- 
<https://www.alejandro-colomar.es/>
Looking for a remote C programming job at the moment.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]