Re: [PATCH v4] man2: add MPOL_WEIGHTED_INTERLEAVE documentation

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2357 bytes --]

On Mon, Mar 18, 2024 at 02:38:48PM +0000, Svetly Todorov wrote:
> Happy Monday Alex,

Happy Monday Svetly!

> Thanks for looking at this over the weekend! Hopefully
> not too many more changes to go.

Nah, I think we're almost done.  The patch LGTM.

> > We should document the kernel version that added this.
> > Please look for other (since ...) in the same page
> > 
> > Have a lovely night!
> > Alex
> 
> I was referencing MPOL_LOCAL in the same page and there are
> two commits listed under it:
> 
> > .BR MPOL_LOCAL " (since Linux 3.8)”
> > .\" commit 479e2802d09f1e18a97262c4c6f8f17ae5884bd8
> > .\" commit f2a07f40dbc603c15f8b06e6ec7f768af67b424f
> 
> I want to add a similar comment for MPOL_WEIGHTED_INTERLEAVE
> but I’m not sure what the equivalent would be.
> I’m thinking to have something like
> 
> > .BR MPOL_WEIGHTED_INTERLEAVE " since (Linux 6.9)"

Yes, the above is fine.

> > .\" commit fa3bea4e1f8202d787709b7e3654eb0a99aed758

And yeah, this is good too.

> Where fa3bea... is the commit in the kernel git
> for the weighted interleave patch:

Yup.  That commit is already in Linus's tree:

alx@debian:~/src/linux/linux/master$ git describe --contains fa3bea4e1f82
fatal: cannot describe 'fa3bea4e1f8202d787709b7e3654eb0a99aed758'
alx@debian:~/src/linux/linux/master$ git describe fa3bea4e1f82
v6.8-rc5-108-gfa3bea4e1f82
alx@debian:~/src/linux/linux/master$ git log --oneline torvalds/master | grep fa3bea4e1f82
fa3bea4e1f82 mm/mempolicy: introduce MPOL_WEIGHTED_INTERLEAVE for weighted interleaving

> https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-stable-2024-03-13-20-04&id=fa3bea4e1f8202d787709b7e3654eb0a99aed758
> 
> (Forgive me, not sure if there’s a way to shorten long links like that).

No problem.  I don't either.  :)

> I can’t tell why there are two commits listed under MPOL_LOCAL, though. 

Maybe one commit significantly changed the feature.  Don't worry;
normally there's just 1 commit listed in the comments.

> Do you think just fa3ea... would be sufficient?

Yup!  Please send and I'll apply already.  (And remember to add the
'Reviewed-by: "Huang, Ying" <ying.huang@intel.com>'.)

Cheers,
Alex

> 
> Svetly
> 

-- 
<https://www.alejandro-colomar.es/>
Looking for a remote C programming job at the moment.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]