Re: [PATCH] mount_setattr.2: Update supported file-systems

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2533 bytes --]

Hi Rodrigo,

On Tue, Apr 09, 2024 at 03:10:46PM +0100, Rodrigo Campos wrote:
> Let's update the list with the last file-systems that added support.
> 
> You can easily verify this by "git grep FS_ALLOW_IDMAP" on the given Linux
> version to see that the fs is listed and then checkout the previous Linux
> version to see that it is not listed, therefore it was added in that version.

You could add the following to the commit message:

$ diff -w -U0 \
	<(git grep FS_ALLOW_IDMAP v6.8 | sed 's/^v6.8://') \
	<(git grep FS_ALLOW_IDMAP v6.9-rc4 | sed 's/^v6.9-rc4://') \
| tail -n+4;
+fs/hugetlbfs/inode.c:	.fs_flags               = FS_ALLOW_IDMAP,

$ diff -w -U0 \
	<(git grep FS_ALLOW_IDMAP v6.6 | sed 's/^v6.6://') \
	<(git grep FS_ALLOW_IDMAP v6.7 | sed 's/^v6.7://') \
| tail -n+4;
+fs/ceph/super.c:	.fs_flags	= FS_RENAME_DOES_D_MOVE | FS_ALLOW_IDMAP,
$ diff -w -U0 \
	<(git grep FS_ALLOW_IDMAP v6.2 | sed 's/^v6.2://') \
	<(git grep FS_ALLOW_IDMAP v6.3 | sed 's/^v6.3://') \
| tail -n+4;
+mm/shmem.c:	.fs_flags	= FS_USERNS_MOUNT | FS_ALLOW_IDMAP,
$ diff -w -U0 \
	<(git grep FS_ALLOW_IDMAP v6.1 | sed 's/^v6.1://') \
	<(git grep FS_ALLOW_IDMAP v6.2 | sed 's/^v6.2://') \
| tail -n+4;
+fs/squashfs/super.c:	.fs_flags = FS_REQUIRES_DEV | FS_ALLOW_IDMAP,


> 
> Signed-off-by: Rodrigo Campos <rodrigo@sdfg.com.ar>
> ---
> 
> I've took the liberty of adding hugetlbfs that was merged in Linux 6.9-rc1 but there is still no
> final release of 6.9. Please feel free to drop that if you prefer to wait for the final release to
> include it.

Are you confident that it will be in 6.9?  If so, I don't mind having it
already in the manual.

> 
> 
> Best,
> Rodrigo
> 
> ---
>  man2/mount_setattr.2 | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/man2/mount_setattr.2 b/man2/mount_setattr.2
> index 3b70dcd97..f4bbc088b 100644
> --- a/man2/mount_setattr.2
> +++ b/man2/mount_setattr.2
> @@ -667,6 +667,18 @@ Currently, the following filesystems support ID-mapped mounts:
>  .IP \[bu]
>  .B overlayfs
>  (ID-mapped lower and upper layers supported since Linux 5.19)
> +.IP \[bu]
> +.B squashfs
> +(since Linux 6.2)
> +.IP \[bu]
> +.B tmpfs
> +(since Linux 6.3)
> +.IP \[bu]
> +.B cephfs
> +(since Linux 6.7)
> +.IP \[bu]
> +.B hugetlbfs
> +(since Linux 6.9)

I checked that all of them seem to be correct.  Thanks!

Have a lovely day!
Alex

>  .PD
>  .RE
>  .IP \[bu]
> -- 
> 2.43.0
> 

-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]