* [PATCH v7] man2: add MPOL_WEIGHTED_INTERLEAVE documentation
@ 2024-04-23 23:36 Svetly Todorov
2024-04-23 23:46 ` Alejandro Colomar
0 siblings, 1 reply; 2+ messages in thread
From: Svetly Todorov @ 2024-04-23 23:36 UTC (permalink / raw)
To: alx; +Cc: linux-man, gregory.price, ying.huang, Svetly Todorov
---
Adding documentation for the new MPOL_WEIGHTED_INTERLEAVE mode in the same
manpages that mention MPOL_INTERLEAVE; namely, mbind(2), set_mempolicy(2),
and get_mempolicy(2).
Descriptions were based on the changes introduced in this patch:
https://lore.kernel.org/all/20240202170238.90004-4-gregory.price@memverge.com/
Which was upstreamed to 6.9 here:
https://lore.kernel.org/linux-mm/20240313200532.34e4cff216acd3db8def4637@linux-foundation.org/
To: alx@kernel.org
Cc: linux-man@vger.kernel.org
Cc: gregory.price@memverge.com
Cc: ying.huang@intel.com
Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
Signed-off-by: Svetly Todorov <svetly.todorov@memverge.com>
Changes in v7:
- raised -> set
- Link to v6: https://lore.kernel.org/r/20240402-weighted_interleave-v6-1-4c2891901352@memverge.com
Changes in v6:
- either/or -> neither/nor
- remove version parentheticals in get_mempolicy.2
- Link to v5: https://lore.kernel.org/r/20240318-weighted_interleave-v5-1-c821a46d5beb@memverge.com
Changes in v5:
- document kernel version where WEIGHTED_INTERLEAVE was added
- Link to v4: https://lore.kernel.org/r/20240316-weighted_interleave-v4-1-6ab516f12ced@memverge.com
Changes in v4:
- BR -> B in get_mempolicy
- use roman for ellipses; format using \|
- Link to v3: https://lore.kernel.org/r/20240315-weighted_interleave-v3-1-416a1ab01524@memverge.com
Changes in v3:
- italicize paths
- Link to v2: https://lore.kernel.org/r/20240315-weighted_interleave-v2-1-b742a48750b0@memverge.com
Changes in v2:
- make flag documentation implementation-agnostic
- Link to v1: https://lore.kernel.org/r/20240314-weighted_interleave-v1-1-ce85d64db0d4@memverge.com
---
man2/get_mempolicy.2 | 10 +++++++---
man2/mbind.2 | 18 ++++++++++++++++++
man2/set_mempolicy.2 | 18 ++++++++++++++++++
3 files changed, 43 insertions(+), 3 deletions(-)
diff --git a/man2/get_mempolicy.2 b/man2/get_mempolicy.2
index 5248f04ba..f6f80ab3e 100644
--- a/man2/get_mempolicy.2
+++ b/man2/get_mempolicy.2
@@ -137,7 +137,9 @@ specifies
but not
.BR MPOL_F_ADDR ,
and the thread's current policy is
-.BR MPOL_INTERLEAVE ,
+.B MPOL_INTERLEAVE
+or
+.BR MPOL_WEIGHTED_INTERLEAVE ,
then
.BR get_mempolicy ()
will return in the location pointed to by a non-NULL
@@ -205,8 +207,10 @@ specified
.B MPOL_F_NODE
but not
.B MPOL_F_ADDR
-and the current thread policy is not
-.BR MPOL_INTERLEAVE .
+and the current thread policy is neither
+.B MPOL_INTERLEAVE
+nor
+.BR MPOL_WEIGHTED_INTERLEAVE .
Or,
.I flags
specified
diff --git a/man2/mbind.2 b/man2/mbind.2
index b0e961f9c..96264ce81 100644
--- a/man2/mbind.2
+++ b/man2/mbind.2
@@ -105,6 +105,7 @@ argument must specify one of
.BR MPOL_DEFAULT ,
.BR MPOL_BIND ,
.BR MPOL_INTERLEAVE ,
+.BR MPOL_WEIGHTED_INTERLEAVE ,
.BR MPOL_PREFERRED ,
or
.B MPOL_LOCAL
@@ -243,6 +244,23 @@ at least 1\ MB or bigger with a fairly uniform access pattern.
Accesses to a single page of the area will still be limited to
the memory bandwidth of a single node.
.TP
+.BR MPOL_WEIGHTED_INTERLEAVE " (since Linux 6.9)"
+.\" commit fa3bea4e1f8202d787709b7e3654eb0a99aed758
+This mode interleaves page allocations across the nodes specified in
+.I nodemask
+according to the weights in
+.IR /sys/kernel/mm/mempolicy/weighted_interleave .
+For example, if bits 0, 2, and 5 are set in
+.IR nodemask ,
+and the contents of
+.IR /sys/kernel/mm/mempolicy/weighted_interleave/node0 ,
+.IR /sys/ .\|.\|. /node2 ,
+and
+.IR /sys/ .\|.\|. /node5
+are 4, 7, and 9, respectively,
+then pages in this region will be allocated on nodes 0, 2, and 5
+in a 4:7:9 ratio.
+.TP
.B MPOL_PREFERRED
This mode sets the preferred node for allocation.
The kernel will try to allocate pages from this
diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2
index fc3ad9df8..f1f225e32 100644
--- a/man2/set_mempolicy.2
+++ b/man2/set_mempolicy.2
@@ -63,6 +63,7 @@ argument must specify one of
.BR MPOL_DEFAULT ,
.BR MPOL_BIND ,
.BR MPOL_INTERLEAVE ,
+.BR MPOL_WEIGHTED_INTERLEAVE ,
.BR MPOL_PREFERRED ,
or
.B MPOL_LOCAL
@@ -199,6 +200,23 @@ the memory bandwidth of a single node.
.\" To be effective the memory area should be fairly large,
.\" at least 1 MB or bigger.
.TP
+.BR MPOL_WEIGHTED_INTERLEAVE " (since Linux 6.9)"
+.\" commit fa3bea4e1f8202d787709b7e3654eb0a99aed758
+This mode interleaves page allocations across the nodes specified in
+.I nodemask
+according to the weights in
+.IR /sys/kernel/mm/mempolicy/weighted_interleave .
+For example, if bits 0, 2, and 5 are set in
+.IR nodemask ,
+and the contents of
+.IR /sys/kernel/mm/mempolicy/weighted_interleave/node0 ,
+.IR /sys/ .\|.\|. /node2 ,
+and
+.IR /sys/ .\|.\|. /node5
+are 4, 7, and 9, respectively,
+then pages in this region will be allocated on nodes 0, 2, and 5
+in a 4:7:9 ratio.
+.TP
.B MPOL_PREFERRED
This mode sets the preferred node for allocation.
The kernel will try to allocate pages from this node first
---
base-commit: a4ea5f76215dcf1d8d017eb65ab12919ccf09f3f
change-id: 20240313-weighted_interleave-e8141ed754f9
Best regards,
--
Svetly Todorov <svetly.todorov@memverge.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v7] man2: add MPOL_WEIGHTED_INTERLEAVE documentation
2024-04-23 23:36 [PATCH v7] man2: add MPOL_WEIGHTED_INTERLEAVE documentation Svetly Todorov
@ 2024-04-23 23:46 ` Alejandro Colomar
0 siblings, 0 replies; 2+ messages in thread
From: Alejandro Colomar @ 2024-04-23 23:46 UTC (permalink / raw)
To: Svetly Todorov; +Cc: linux-man, gregory.price, ying.huang
[-- Attachment #1: Type: text/plain, Size: 6154 bytes --]
Hi Svetly,
On Tue, Apr 23, 2024 at 11:28:31PM +0000, Svetly Todorov wrote:
> Hi Alex,
>
> Surprised I missed this message. Better late than never, I hope...
No problem! :-)
On Tue, Apr 23, 2024 at 04:36:56PM -0700, Svetly Todorov wrote:
> ---
> Adding documentation for the new MPOL_WEIGHTED_INTERLEAVE mode in the same
> manpages that mention MPOL_INTERLEAVE; namely, mbind(2), set_mempolicy(2),
> and get_mempolicy(2).
>
> Descriptions were based on the changes introduced in this patch:
> https://lore.kernel.org/all/20240202170238.90004-4-gregory.price@memverge.com/
>
> Which was upstreamed to 6.9 here:
> https://lore.kernel.org/linux-mm/20240313200532.34e4cff216acd3db8def4637@linux-foundation.org/
>
> To: alx@kernel.org
> Cc: linux-man@vger.kernel.org
> Cc: gregory.price@memverge.com
> Cc: ying.huang@intel.com
> Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
> Signed-off-by: Svetly Todorov <svetly.todorov@memverge.com>
Minor inconvenience: I'd prefer if the above was inside the commit
message. Anyway, I've pasted it in; not a big problem.
Patch applied.
<https://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/?h=contrib&id=72134eef4e525dd2d882aee4cbd5b79e2ee347fd>
Have a lovely night!
Alex
> Changes in v7:
> - raised -> set
> - Link to v6: https://lore.kernel.org/r/20240402-weighted_interleave-v6-1-4c2891901352@memverge.com
>
> Changes in v6:
> - either/or -> neither/nor
> - remove version parentheticals in get_mempolicy.2
> - Link to v5: https://lore.kernel.org/r/20240318-weighted_interleave-v5-1-c821a46d5beb@memverge.com
>
> Changes in v5:
> - document kernel version where WEIGHTED_INTERLEAVE was added
> - Link to v4: https://lore.kernel.org/r/20240316-weighted_interleave-v4-1-6ab516f12ced@memverge.com
>
> Changes in v4:
> - BR -> B in get_mempolicy
> - use roman for ellipses; format using \|
> - Link to v3: https://lore.kernel.org/r/20240315-weighted_interleave-v3-1-416a1ab01524@memverge.com
>
> Changes in v3:
> - italicize paths
> - Link to v2: https://lore.kernel.org/r/20240315-weighted_interleave-v2-1-b742a48750b0@memverge.com
>
> Changes in v2:
> - make flag documentation implementation-agnostic
> - Link to v1: https://lore.kernel.org/r/20240314-weighted_interleave-v1-1-ce85d64db0d4@memverge.com
> ---
> man2/get_mempolicy.2 | 10 +++++++---
> man2/mbind.2 | 18 ++++++++++++++++++
> man2/set_mempolicy.2 | 18 ++++++++++++++++++
> 3 files changed, 43 insertions(+), 3 deletions(-)
>
> diff --git a/man2/get_mempolicy.2 b/man2/get_mempolicy.2
> index 5248f04ba..f6f80ab3e 100644
> --- a/man2/get_mempolicy.2
> +++ b/man2/get_mempolicy.2
> @@ -137,7 +137,9 @@ specifies
> but not
> .BR MPOL_F_ADDR ,
> and the thread's current policy is
> -.BR MPOL_INTERLEAVE ,
> +.B MPOL_INTERLEAVE
> +or
> +.BR MPOL_WEIGHTED_INTERLEAVE ,
> then
> .BR get_mempolicy ()
> will return in the location pointed to by a non-NULL
> @@ -205,8 +207,10 @@ specified
> .B MPOL_F_NODE
> but not
> .B MPOL_F_ADDR
> -and the current thread policy is not
> -.BR MPOL_INTERLEAVE .
> +and the current thread policy is neither
> +.B MPOL_INTERLEAVE
> +nor
> +.BR MPOL_WEIGHTED_INTERLEAVE .
> Or,
> .I flags
> specified
> diff --git a/man2/mbind.2 b/man2/mbind.2
> index b0e961f9c..96264ce81 100644
> --- a/man2/mbind.2
> +++ b/man2/mbind.2
> @@ -105,6 +105,7 @@ argument must specify one of
> .BR MPOL_DEFAULT ,
> .BR MPOL_BIND ,
> .BR MPOL_INTERLEAVE ,
> +.BR MPOL_WEIGHTED_INTERLEAVE ,
> .BR MPOL_PREFERRED ,
> or
> .B MPOL_LOCAL
> @@ -243,6 +244,23 @@ at least 1\ MB or bigger with a fairly uniform access pattern.
> Accesses to a single page of the area will still be limited to
> the memory bandwidth of a single node.
> .TP
> +.BR MPOL_WEIGHTED_INTERLEAVE " (since Linux 6.9)"
> +.\" commit fa3bea4e1f8202d787709b7e3654eb0a99aed758
> +This mode interleaves page allocations across the nodes specified in
> +.I nodemask
> +according to the weights in
> +.IR /sys/kernel/mm/mempolicy/weighted_interleave .
> +For example, if bits 0, 2, and 5 are set in
> +.IR nodemask ,
> +and the contents of
> +.IR /sys/kernel/mm/mempolicy/weighted_interleave/node0 ,
> +.IR /sys/ .\|.\|. /node2 ,
> +and
> +.IR /sys/ .\|.\|. /node5
> +are 4, 7, and 9, respectively,
> +then pages in this region will be allocated on nodes 0, 2, and 5
> +in a 4:7:9 ratio.
> +.TP
> .B MPOL_PREFERRED
> This mode sets the preferred node for allocation.
> The kernel will try to allocate pages from this
> diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2
> index fc3ad9df8..f1f225e32 100644
> --- a/man2/set_mempolicy.2
> +++ b/man2/set_mempolicy.2
> @@ -63,6 +63,7 @@ argument must specify one of
> .BR MPOL_DEFAULT ,
> .BR MPOL_BIND ,
> .BR MPOL_INTERLEAVE ,
> +.BR MPOL_WEIGHTED_INTERLEAVE ,
> .BR MPOL_PREFERRED ,
> or
> .B MPOL_LOCAL
> @@ -199,6 +200,23 @@ the memory bandwidth of a single node.
> .\" To be effective the memory area should be fairly large,
> .\" at least 1 MB or bigger.
> .TP
> +.BR MPOL_WEIGHTED_INTERLEAVE " (since Linux 6.9)"
> +.\" commit fa3bea4e1f8202d787709b7e3654eb0a99aed758
> +This mode interleaves page allocations across the nodes specified in
> +.I nodemask
> +according to the weights in
> +.IR /sys/kernel/mm/mempolicy/weighted_interleave .
> +For example, if bits 0, 2, and 5 are set in
> +.IR nodemask ,
> +and the contents of
> +.IR /sys/kernel/mm/mempolicy/weighted_interleave/node0 ,
> +.IR /sys/ .\|.\|. /node2 ,
> +and
> +.IR /sys/ .\|.\|. /node5
> +are 4, 7, and 9, respectively,
> +then pages in this region will be allocated on nodes 0, 2, and 5
> +in a 4:7:9 ratio.
> +.TP
> .B MPOL_PREFERRED
> This mode sets the preferred node for allocation.
> The kernel will try to allocate pages from this node first
>
> ---
> base-commit: a4ea5f76215dcf1d8d017eb65ab12919ccf09f3f
> change-id: 20240313-weighted_interleave-e8141ed754f9
>
> Best regards,
> --
> Svetly Todorov <svetly.todorov@memverge.com>
>
--
<https://www.alejandro-colomar.es/>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-23 23:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-23 23:36 [PATCH v7] man2: add MPOL_WEIGHTED_INTERLEAVE documentation Svetly Todorov
2024-04-23 23:46 ` Alejandro Colomar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox