From: "Günther Noack" <gnoack@google.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: linux-man@vger.kernel.org,
"Mickaël Salaün" <mic@linux.microsoft.com>,
"Mickaël Salaün" <mic@digikod.net>,
"Alejandro Colomar" <alx@kernel.org>,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH 1/1] landlock: Mention -1 return code on failure
Date: Fri, 12 Jul 2024 15:35:38 +0200 [thread overview]
Message-ID: <ZpExKpaDvxj3tqBN@google.com> (raw)
In-Reply-To: <20240712130904.145010-1-pvorel@suse.cz>
On Fri, Jul 12, 2024 at 03:09:04PM +0200, Petr Vorel wrote:
> Mention -1 return code on failure for landlock_add_rule(),
> landlock_create_ruleset() and landlock_restrict_self().
>
> Although it's a common rule to return -1 on error, it's better to be
> explicit (as the other man pages are).
>
> Fixes: a01d04a69 ("landlock_add_rule.2: Document new syscall")
> Fixes: ca5163697 ("landlock_create_ruleset.2: Document new syscall")
> Fixes: 3f7e4f808 ("landlock_restrict_self.2: Document new syscall")
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> FYI we test return codes in LTP.
>
> https://lore.kernel.org/ltp/20240711-landlock-v3-0-c7b0e9edf9b0@suse.com/
> https://lore.kernel.org/ltp/20240711201306.98519-1-pvorel@suse.cz/
Thank you, Petr! This looks good.
(Please apply Alejandro's rewording suggestion as well.)
Reviewed-by: Günther Noack <gnoack@google.com>
—Günther
prev parent reply other threads:[~2024-07-12 13:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 13:09 [PATCH 1/1] landlock: Mention -1 return code on failure Petr Vorel
2024-07-12 13:13 ` Alejandro Colomar
2024-07-12 13:25 ` Petr Vorel
2024-07-12 13:26 ` Alejandro Colomar
2024-07-12 13:35 ` Günther Noack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpExKpaDvxj3tqBN@google.com \
--to=gnoack@google.com \
--cc=alx@kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@digikod.net \
--cc=mic@linux.microsoft.com \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox