Re: [PATCH v2] man/man3/strftime.3: Check parameter

["Dr. David Alan Gilbert" <dave@treblig.org>]

* Alejandro Colomar (alx@kernel.org) wrote:
> Hi Dave,
> 
> On Mon, Aug 18, 2025 at 06:45:53PM +0100, dave@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <dave@treblig.org>
> > 
> > The strftime example requires a format paramter.  If you don't
> > pass one it crashes.
> > Check for the parameter.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> 
> Thanks!  I've applied the patch.  (But see some minor comment below.)

Thanks!
Is that something that I can spot locally?
Since I seem to be working my way through the set checking most of the
examples, I'm probably going to be posting some more so I should
get the checks running.

I'm trying to run:
   make -R lint build-all check

but it seems to be missing 'checkpatch' and I'm not sure which checkpatch
that is. (I'm on Fedora 42).

Dave

> 
> Have a lovely day!
> Alex
> 
> > ---
> >  v2
> >     Use a more standard Usage: format.
> > 
> >  man/man3/strftime.3 | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/man/man3/strftime.3 b/man/man3/strftime.3
> > index 4a3f805bb..a27dfd01b 100644
> > --- a/man/man3/strftime.3
> > +++ b/man/man3/strftime.3
> > @@ -739,6 +739,11 @@ .SS Program source
> >      char outstr[200];
> >      time_t t;
> >      struct tm *tmp;
> > +\&
> > +    if (argc != 2) {
> > +        fprintf(stderr,"Usage: %s: <format\-string>\[rs]n", argv[0]);
> 
> CI detected some issue in this line of code:
> 
> 	remote: .tmp/man/man3/strftime.3.d/strftime.c:14:  Missing space after ,  [whitespace/comma] [3]
> 
> I've amended it with a space.
> 
> > +        exit(EXIT_FAILURE);
> > +    }
> >  \&
> >      t = time(NULL);
> >      tmp = localtime(&t);
> > -- 
> > 2.50.1
> > 
> 
> -- 
> <https://www.alejandro-colomar.es/>


-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/