Re: [PATCH v2] man/man3/strftime.3: Check parameter

["Dr. David Alan Gilbert" <dave@treblig.org>]

* Alejandro Colomar (alx@kernel.org) wrote:
> Hi Dave,
> 
> On Tue, Aug 19, 2025 at 11:46:07AM +0000, Dr. David Alan Gilbert wrote:
> > * Alejandro Colomar (alx@kernel.org) wrote:
> > > Hi Dave,
> > > 
> > > On Mon, Aug 18, 2025 at 06:45:53PM +0100, dave@treblig.org wrote:
> > > > From: "Dr. David Alan Gilbert" <dave@treblig.org>
> > > > 
> > > > The strftime example requires a format paramter.  If you don't
> > > > pass one it crashes.
> > > > Check for the parameter.
> > > > 
> > > > Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> > > 
> > > Thanks!  I've applied the patch.  (But see some minor comment below.)
> > 
> > Thanks!
> > Is that something that I can spot locally?
> > Since I seem to be working my way through the set checking most of the
> > examples, I'm probably going to be posting some more so I should
> > get the checks running.
> 
> Yes, you can.
> 
> > I'm trying to run:
> >    make -R lint build-all check
> 
> This is essentially what it does.  Here's the full script I use in my
> server (the linters are run on pushes to refs/heads/contrib):
> 
> 	alx@www:/srv/src/alx/linux/man-pages/man-pages.git$ cat hooks/post-update;
> 	#!/bin/bash
> 
> 	set -uo pipefail;
> 
> 	cd /home/alx/src/linux/man-pages/man-pages/.bare.git/;
> 
> 	unset $(git rev-parse --local-env-vars);
> 	git fetch srv >/dev/null;
> 
> 	export LANG=C.utf8;
> 
> 	test "$1" = "refs/heads/main" \
> 	&& (
> 		cd /home/alx/src/linux/man-pages/man-pages/main/;
> 
> 		git reset srv/main --hard >/dev/null;
> 
> 		export pdfdir="/srv/www/share/dist/man-pages/git/HEAD";
> 		export DISTNAME="man-pages-HEAD";
> 
> 		make -R install-pdf-book 2>&1 \
> 		| sed '/bashrc.*PS1/d';
> 		echo '$?: '"$?";
> 	)
> 
> 	test "$1" = "refs/heads/contrib" \
> 	&& (
> 		set -Ee;
> 
> 		export PS1=;
> 		cd /home/alx/src/linux/man-pages/man-pages/contrib/;
> 
> 		old="$(git rev-parse HEAD)";
> 
> 		git reset srv/contrib --hard >/dev/null;
> 
> 		make_opts='';
> 		make_opts="$make_opts -R";
> 		make_opts="$make_opts -j4";
> 		make_opts="$make_opts -Otarget";
> 		make_opts="$make_opts --no-print-directory";
> 
> 		export VERSION=contrib;
> 		#export GROFFBINDIR=/opt/local/gnu/groff/deri-gropdf-ng/bin;
> 		#export PRECONV=$GROFFBINDIR/preconv;
> 		#export PIC=$GROFFBINDIR/pic;
> 		#export TBL=$GROFFBINDIR/tbl;
> 		#export EQN=$GROFFBINDIR/eqn;
> 		#export TROFF=$GROFFBINDIR/troff;
> 		#export GROPDF=$GROFFBINDIR/gropdf;
> 
> 		make_target()
> 		{
> 			make $make_opts "$@" 2>&1 \
> 			| sed '/bashrc.*PS1/d';
> 		}
> 
> 		make_target lint;
> 		make_target build-pdf-book;
> 		make_target build-all;
> 		make_target check;
> 		make_target dist;
> 		echo '$?: '"$?";
> 
> 		echo 'URI:';
> 		git rev-list "$old..HEAD" \
> 		| sed 's,.*,https://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/?h=contrib\&id=&,';
> 	)
> 
> > but it seems to be missing 'checkpatch' and I'm not sure which checkpatch
> > that is. (I'm on Fedora 42).
> 
> Yup, checkpatch is the one you can't run.  I have a fork of the kernel's
> checkpatch, which I want to eventually package.  I need to find some
> time to do it.
> 
> For now, you should be able to do what CONTRIBUTING.d/lint says about
> make's -t and -k options, which will allow you to ignore those failures.
> Let me know if that doesn't work.

OK great, I'll give those a go and hopefully you'll see some more patches!

Dave

> 
> Have a lovely day!
> Alex
> 
> -- 
> <https://www.alejandro-colomar.es/>


-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/