Hi Ben, > Subject: Re: [PATCH] man/man2/mmap.2: Document that MAP_GROWSDOWN > doesn't affect mmap return value. Please include patch version in the [] prefix. See . Also, please send In-Reply-To previous iterations. See And ideally, include a range-diff that compares the patch against the previous iteration. See . On 2026-03-17T17:46:52-0400, Ben Kallus wrote: > The man page states that the MAP_GROWSDOWN flag causes the kernel to return an > address one page lower than the mapping created. This is not true; the kernel Please use two spaces after period. See . > returns the base address of the mapping created, just as it does when > MAP_GROWSDOWN is not passed. This can be confirmed by inspecting > /proc/self/maps after making a gd mapping, and comparing it to the returned > value from mmap. Please include in the commit message the example program you sent in the previous thread about this patch. > Fixes: 176b1a76 (2016-11-21; "mmap.2: Add (much) more detail on MAP_GROWSDOWN") > > Signed-off-by: Ben Kallus Please no blank lines between Fixes and SoB. The trailer should be a single block. Have a lovely night! Alex > --- > man/man2/mmap.2 | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/man/man2/mmap.2 b/man/man2/mmap.2 > index 09e7933d3..20b94c243 100644 > --- a/man/man2/mmap.2 > +++ b/man/man2/mmap.2 > @@ -276,8 +276,6 @@ should check the returned address against the requested address. > This flag is used for stacks. > It indicates to the kernel virtual memory system that the mapping > should extend downward in memory. > -The return address is one page lower than the memory area that is > -actually created in the process's virtual address space. > Touching an address in the "guard" page below the mapping will cause > the mapping to grow by a page. > This growth can be repeated until the mapping grows to within a > -- > 2.53.0 > > --