From: Alejandro Colomar <alx@kernel.org>
To: Tomasz Kramkowski <tomasz@kramkow.ski>
Cc: linux-man@vger.kernel.org
Subject: Re: [PATCH] man/man2/ioctl_tty.2: Fix references to TCSETS(2const)
Date: Sun, 3 May 2026 23:14:51 +0200 [thread overview]
Message-ID: <afe6kmdqSAY6HrR7@devuan> (raw)
In-Reply-To: <20260501145701.66573-1-tomasz@kramkow.ski>
[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]
Hi Tomasz,
On 2026-05-01T15:57:01+0100, Tomasz Kramkowski wrote:
> Change the duplicate references to refer to all of the different
> variants of the TC{GET,SET{S,S2,W}{,W,F}} constants.
>
> This looks to be a bug which was introduced during a restructuring.
Would you mind adding a Fixes:' tag for that bug? It would help for
reviewing.
See <https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING.d/patches/trailer#n16>
and <https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING.d/git#n46>.
Have a lovely night!
Alex
>
> Signed-off-by: Tomasz Kramkowski <tomasz@kramkow.ski>
> ---
> man/man2/ioctl_tty.2 | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/man/man2/ioctl_tty.2 b/man/man2/ioctl_tty.2
> index 1d6e279c0..cb2776867 100644
> --- a/man/man2/ioctl_tty.2
> +++ b/man/man2/ioctl_tty.2
> @@ -42,21 +42,21 @@ whenever possible.
> .TQ
> .BR TCSETSF (2const)
> .TP
> -.BR TCGETS (2const)
> +.BR TCGETS2 (2const)
> .TQ
> -.BR TCSETS (2const)
> +.BR TCSETS2 (2const)
> .TQ
> -.BR TCSETSW (2const)
> +.BR TCSETSW2 (2const)
> .TQ
> -.BR TCSETSF (2const)
> +.BR TCSETSF2 (2const)
> .TP
> -.BR TCGETS (2const)
> +.BR TCGETA (2const)
> .TQ
> -.BR TCSETS (2const)
> +.BR TCSETA (2const)
> .TQ
> -.BR TCSETSW (2const)
> +.BR TCSETAW (2const)
> .TQ
> -.BR TCSETSF (2const)
> +.BR TCSETAF (2const)
> .SS Locking the termios structure
> .TP
> .BR TIOCGLCKTRMIOS (2const)
> --
> 2.51.0
>
--
<https://www.alejandro-colomar.es>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-05-03 21:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 14:57 [PATCH] man/man2/ioctl_tty.2: Fix references to TCSETS(2const) Tomasz Kramkowski
2026-05-03 21:14 ` Alejandro Colomar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afe6kmdqSAY6HrR7@devuan \
--to=alx@kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=tomasz@kramkow.ski \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox