Hi ChaseKnowlden,

> Subject: Re: [PATCH] man/man2/seccomp.2: Fix signal.h type conflict with glibc in seccomp.2

On 2026-05-20T17:32:58-0400, ChaseKnowlden wrote:
> Signed-off-by: ChaseKnowlden <haroldknowlden@gmail.com>

You should say something more in the commit message.  What type conflict
do you have?  Why is this fix correct?  It would be good to link to
other sources that confirm this, and/or CC glibc.

> ---
>  man/man2/seccomp.2 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man/man2/seccomp.2 b/man/man2/seccomp.2
> index e469f3997..8b8f2fc61 100644
> --- a/man/man2/seccomp.2
> +++ b/man/man2/seccomp.2
> @@ -16,7 +16,7 @@ Standard C library
>  .BR "#include <linux/seccomp.h>" "  /* Definition of " SECCOMP_* " constants */"
>  .BR "#include <linux/filter.h>" "   /* Definition of " "struct sock_fprog" " */"
>  .BR "#include <linux/audit.h>" "    /* Definition of " AUDIT_* " constants */"
> -.BR "#include <linux/signal.h>" "   /* Definition of " SIG* " constants */"
> +.BR "#include <signal.h>" "   /* Definition of " SIG* " constants */"

Please keep the alignment of the comments.


Have a lovely night!
Alex

>  .BR "#include <sys/ptrace.h>" "     /* Definition of " PTRACE_* " constants */"
>  .\" Kees Cook noted: Anything that uses SECCOMP_RET_TRACE returns will
>  .\"                  need <sys/ptrace.h>
> -- 
> 2.54.0
> 
> 

-- 
<https://www.alejandro-colomar.es>