From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF55042EECA for ; Mon, 18 May 2026 12:51:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779108708; cv=none; b=QhrnBMNhrrRCZzrpUqGk/GknQMGSGhwKH08/839Tt6N0Iu7eiiiX5HBVFBV19YGX8tlOYYiIZ1S86f2Qnfa9Z+RVFBq4N8oxfvtI3yeHdvk/4ElTOEblEp9Qx8R8CGcX6MtBOq5nMlb6DCWwiHsoaj3X5BPSTgp8OZtfIVBpJTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779108708; c=relaxed/simple; bh=1XmJUe41SqTPAv3V8ijHtr230/ADVigjdaz1TcnSUM8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=j04b4ExrUjpPF1xSEzKxdbqSjNMv212jYc9lJ7spOM5YzRYP5rx2w9voHb3PgeIWu6UrX+9H+GG2xUXeV4xCrqfhiBR5mmeTThGC3dIwLx4FgUHhvBKb5mkYrYLC2AT81n1WwKUOiyz34Bax+Zy4eGK+j73VqKfyu6u7JCRFwZg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=txnrFgmN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="txnrFgmN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F0B9C2BCB7; Mon, 18 May 2026 12:51:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779108708; bh=1XmJUe41SqTPAv3V8ijHtr230/ADVigjdaz1TcnSUM8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=txnrFgmN+HHj+cfnTnJTFJ3swBwpCtnw/r8GdoBz4Ox7Ru5j17sbwlgZ9uXyQeDU3 Y6pqwsQEJEmMgmy4VXBkvgsRuKzhXVdetaqJs2aaHeEdKj8shyivpsqTAmse/Ctu+L ei2tcJm0Sj/3UClYJsRxH7ZkqGbSa3fIaCDQfkGLeDLG1r8clCZxGEBqWo5JPeh8JX vcypLBDVs9C91hh5YJjNON30jDjLvueie4oT2p0Z3YtjCH9kUmwGAltfnJTPagI5n6 7DtAHFvhS6MQxhgG98Xll2fVIrw8NqDm+jpH5AeNds35Z7sl2JyzHpaEg0J2Tn9VsI /7RJK4gX6IA+g== Date: Mon, 18 May 2026 14:51:45 +0200 From: Alejandro Colomar To: Jan Kara Cc: linux-man@vger.kernel.org, Petr Gajdos , Jan Blunck Subject: Re: [PATCH v1] man/man2/quotactl.2: tfix Message-ID: References: <9d328eab7a632ac87f48bcfe88c0e5c3cca18d2a.1778951437.git.alx@kernel.org> Precedence: bulk X-Mailing-List: linux-man@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bi2einkuh37g6342" Content-Disposition: inline In-Reply-To: --bi2einkuh37g6342 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable From: Alejandro Colomar To: Jan Kara Cc: linux-man@vger.kernel.org, Petr Gajdos , Jan Blunck Subject: Re: [PATCH v1] man/man2/quotactl.2: tfix Message-ID: References: <9d328eab7a632ac87f48bcfe88c0e5c3cca18d2a.1778951437.git.alx@kernel.org> MIME-Version: 1.0 In-Reply-To: Hi Jan, On 2026-05-18T12:20:50+0200, Jan Kara wrote: > On Sat 16-05-26 19:12:08, Alejandro Colomar wrote: > > It seems most likely that this was a typo, and that Q_XQUOTAON was > > meant. > >=20 > > Fixes: 1eeddf25 (2010-06-16; "quotactl.2: Major updates") > > Cc: Jan Kara > > Cc: Petr Gajdos > > Cc: Jan Blunck > > Signed-off-by: Alejandro Colomar >=20 > Right. Thanks for the fix. Feel free to add: I have more questions about quotactl(2). In the operations that ignore the 'id' argument, am I right to assume that QCMD() is unnecessary? My assumption is because if there's no user or group ID to be used, it also doesn't make sense to specify whether we want to affect a user or a group. So, for example, Q_QUOTAOFF would have the following synopsis: int quotactl(Q_QUOTAOFF, const char *_Nullable special, 0, NULL); While Q_QUOTAON would have the following one: int quotactl(QCMD(Q_QUOTAON, type), const char *_Nullable special, int fmt, caddr_t quota_path); Is that correct? Also, I wonder why caddr_t was used at all, instead of void*. It seems to unnecessarily require a cast, which could have been avoided with void*. In quotactl_fd(), since we need to use syscall(2), which is variadic, I'll document the correct pointer types, instead of caddr_t*. Have a lovely day! Alex --=20 --bi2einkuh37g6342 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEES7Jt9u9GbmlWADAi64mZXMKQwqkFAmoLC1oACgkQ64mZXMKQ wqk1Rg/+I9TTiaoSOnA3xQEklFJREh8bNW4qin7fPd7Xiqeh0H2anahlgdca2P6w lrYRiIE1fJuzoOUoEXm9m+H2j9XnSrYsq5fngiBqpkmU8hWm07NNWlAFs24DC2aw ESVudEe+RtzM7QftHXObAXt0gryUPib0HMHeA0ClIGBH2EYzGsfU3bfISVxk7TTP PI7jMNV/ehG6sgSy5Umlhqbw3/D/+ixE2ZW06h1o7pond0ogH6agLaEkP/q0odO3 ePdJq65wSEUYKjzcDCwRmVTWUPwrJwXQfHXvYcKUI60SsxYk666p8CFChQi1OdV4 uoN46a66ip/xRqPsj0W5LG4glpTdGZmA7L9LOkBNz/hmiTRHDTu617YFZtOS+k7f ZPIlaOqnNwTYMuiZ+OmNfH2IBf4n9aRGKwpOTnfF07h858VKIt8IshENPQXLq995 r8vZRAtTGuWWMpJGlLRtdd5bHpFBfS5gyitMM6iG8h/d3Miy4UBhNpVksemtdben VjLzl0YGaIGQJz161QVG6ZFlVfIWw12/vCI7TVGlRJJA2O9U5FhdOPqBuBzRX3Cr yVJU72lsE6pCyD4R3qsO2BA6ID5Tb4EoUFMdub+zYDA9nXLqJQZ+pVhgaNbK9i7h x4mdAL1cAAs8Z1AKXKvbxvvw4dFBvYL9HlkWC/ZCh+WYqoNP+KM= =NCCJ -----END PGP SIGNATURE----- --bi2einkuh37g6342--