Re: [PATCH] man/man2/statmount.2: Fix incorrect function signature

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1737 bytes --]

Hi Bhavik,

> Date: 2026-08-17 11:07:45+0200
> From: Alejandro Colomar <alx@kernel.org>
>
> Hi Bhavik, Josef,
> 
> > Date: 2026-08-15 13:15:26+0530
> > From: Bhavik Sachdev <b.sachdev1904@gmail.com>
> >
> > flags argument is an unsigned int not an unsigned long [1].
> > 
> > [1]:
> > <https://github.com/torvalds/linux/blob/master/fs/namespace.c#L5961>
> 
> Thanks!
> 
> > Fixes: c011cc992510 (2024-07-09; "statmount.2: Add page")
> 
> Please CC the people involved in that commit.  (I've done it now.)
> 
> > Signed-off-by: Bhavik Sachdev <b.sachdev1904@gmail.com>

Thanks!  I've applied the patch.


Have a lovely day!
Alex

> > ---
> >  man/man2/statmount.2 | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/man/man2/statmount.2 b/man/man2/statmount.2
> > index b6d9dc2a1..a365002dd 100644
> > --- a/man/man2/statmount.2
> > +++ b/man/man2/statmount.2
> > @@ -16,7 +16,7 @@ Standard C library
> >  .P
> >  .BI "int syscall(SYS_statmount, struct mnt_id_req *" req ,
> >  .BI "            struct statmount *" smbuf ", size_t " bufsize ,
> > -.BI "            unsigned long " flags );
> > +.BI "            unsigned int " flags );
> 
> LGTM.
> 
> $ grepc -tfld statmount . | head -n4
> ./fs/namespace.c:SYSCALL_DEFINE4(statmount, const struct mnt_id_req __user *, req,
> 		struct statmount __user *, buf, size_t, bufsize,
> 		unsigned int, flags)
> {
> 
> 
> Josef, was it just a typo, or is there anything that needs checking?
> 
> 
> Have a lovely day!
> Alex
> 
> >  .P
> >  .B #include <linux/mount.h>
> >  .fi
> > -- 
> > 2.53.0
> > 
> > 
> 
> -- 
> <https://www.alejandro-colomar.es>



-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]