Re: [PATCH 1/1] man/man2/request_key.2: Add missing GNU size forward-declarations

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1741 bytes --]

Hi Petr,

> Date: 2026-09-14 13:15:11+0200
> From: Petr Vorel <pvorel@suse.cz>
>
> request_key was left from GNU forward-declarations of parameters for
> sizes of array parameters.
> 
> Fixes: d2c2db883 ("man/: SYNOPSIS: Use GNU forward-declarations of parameters for sizes of array parameters")
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi Alejandro,
> 
> although I don't like N3207 GNU forward-declarations of parameters for
> sizes of array parameters syntax (I'd prefer to have the signatures
> which are in the headers) and I don't think it's practical (before one
> could copy paste the signature from man page), I understand it's a
> wanted feature. Therefore I fixed missing size parameter in request_key.
> 
> I suppose more functions were left in d2c2db883.
> 
> Kind regards,
> Petr
> 
>  man/man2/request_key.2 | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/man/man2/request_key.2 b/man/man2/request_key.2
> index 3bb52f31b..d16642d9f 100644
> --- a/man/man2/request_key.2
> +++ b/man/man2/request_key.2
> @@ -14,7 +14,8 @@ Linux Key Management Utilities
>  .nf
>  .B #include <keyutils.h>
>  .P
> -.BI "key_serial_t request_key(const char *" type ", const char *" description ,
> +.BR "key_serial_t request_key(" "size_t size;"
> +.BI "                         (const char *" type ", const char *" description ,
>  .BI "                         const char *_Nullable " callout_info ,
>  .BI "                         key_serial_t " dest_keyring );

I don't see the 'size' being a parameter of this function at all.  Am
I missing something?


Have a lovely day!
Alex

>  .fi
> -- 
> 2.55.0
> 

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]