Re: [PATCH 01/24] man/man7/unix.7: ERRORS: EINVAL: The address field is sun_family, not sun_type

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1580 bytes --]

Hi Günther!

> Date: 2026-10-16 19:31:16+0200
> From: Günther Noack <gnoack3000@gmail.com>
>
> struct sockaddr_un has no sun_type field; the address family is in
> sun_family, as described in "Address format" above.  The check is done
> by unix_validate_addr() in linux.git net/unix/af_unix.c.
> 
> Assisted-by: LLM
> Signed-off-by: Günther Noack <gnoack3000@gmail.com>
> ---

I'd like to understand the reason why the bogus documentation existed at
all.  For that, a 'Fixes:' tag would be necessary.  It'd also be
interesting to know whether .sun_type was a human hallucination, or it
existed at some point.

In this specific case, it seems to be:

	Fixes: 9d1fd1157306 (1999-06-15, 2022-12-19; "man-pages 1.24")

> Notes:
>     Fixes an obvious typo

Most likely; still worth having a Fixes:.  Since I don't see any
occurences of sun_type in glibc's or Linux's source code, let's assume
it is a typo.

Reviewed-by: Alejandro Colomar <alx@kernel.org>


Have a lovely day!
Alex

> 
>  man/man7/unix.7 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man/man7/unix.7 b/man/man7/unix.7
> index f9db05a71d93..75e125c61673 100644
> --- a/man/man7/unix.7
> +++ b/man/man7/unix.7
> @@ -663,7 +663,7 @@ Invalid argument passed.
>  A common cause is that the value
>  .B AF_UNIX
>  was not specified in the
> -.I sun_type
> +.I sun_family
>  field of passed addresses, or the socket was in an
>  invalid state for the applied operation.
>  .TP
> -- 
> 2.56.0
> 

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]