Re: [PATCH v2 04/24] man/man7/sock_diag.7: Fix member order of struct unix_diag_vfs

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1979 bytes --]

> Date: 2026-10-18 19:36:52+0200
> From: Günther Noack <gnoack3000@gmail.com>
>
> In the kernel's <linux/unix_diag.h>, udiag_vfs_ino comes before
> udiag_vfs_dev, and it has been that way since the structure was added
> in linux.git 5f7b0569460b (2011-12-16; "unix_diag: Unix inode info
> NLA").  Both members are __u32, so code written after the manual page
> would silently mix up the inode and the device number.
> 
> Also reorder the member descriptions to match.
> 
> Fixes: 4f6a0a4a909e (2016-12-07; "sock_diag.7: New page documenting NETLINK_SOCK_DIAG interface")
> Cc: Dmitry V. Levin <ldv@strace.io>
> Cc: Pavel Emelyanov <xemul@virtuozzo.com>
> Cc: Michael Kerrisk <mtk.manpages@gmail.com>
> Assisted-by: LLM
> Signed-off-by: Günther Noack <gnoack3000@gmail.com>
> Reviewed-by: Alejandro Colomar <alx@kernel.org>

Hi!

Thanks!  I've applied patches 1..4.


Have a lovely night!
Alex

> ---
> 
> Notes:
>     Compared against unix_diag.h header,
>     where the struct field order is different.
> 
>  man/man7/sock_diag.7 | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/man/man7/sock_diag.7 b/man/man7/sock_diag.7
> index d4e78c46cc8d..35a6d5a80ffc 100644
> --- a/man/man7/sock_diag.7
> +++ b/man/man7/sock_diag.7
> @@ -180,8 +180,8 @@ structure:
>  .in +4n
>  .EX
>  struct unix_diag_vfs {
> -    __u32 udiag_vfs_dev;
>      __u32 udiag_vfs_ino;
> +    __u32 udiag_vfs_dev;
>  };
>  .EE
>  .in
> @@ -189,11 +189,11 @@ struct unix_diag_vfs {
>  The fields of this structure are as follows:
>  .RS
>  .TP
> -.I udiag_vfs_dev
> -The device number of the corresponding on-disk socket inode.
> -.TP
>  .I udiag_vfs_ino
>  The inode number of the corresponding on-disk socket inode.
> +.TP
> +.I udiag_vfs_dev
> +The device number of the corresponding on-disk socket inode.
>  .RE
>  .TP
>  .B UDIAG_SHOW_PEER
> -- 
> 2.56.0
> 

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]