Re: [PATCH] vdso.7: fix risc-v symbol names.

enh
2023-01-31T17:39:59Z

[-- Attachment #1: Type: text/plain, Size: 1655 bytes --]

On Tue, Jan 31, 2023 at 4:52 AM Alejandro Colomar
<alx.manpages@gmail.com> wrote:
>
> Hi!
>
> On 1/31/23 00:02, enh wrote:
> > The kernel git history says the names have always been "__vdso_" rather
> > than "__kernel_", so I assume this was a copy & paste mistake from a
> > different architecture.
> >
> > Luckily, the path to the kernel source that lets you confirm/deny this
> > _is_ correct :-)
>
> Could you please sign the patch?

done. (i did read that part of the docs, but assumed this counted as a
"trivial" patch :-) )

>
> Also, it seems something is broken in the patch; maybe the mailer broke it? I
> can't seem to apply it. Please check.

ugh, yeah, gmail and tabs really don't get on, and this file is full
of tabs. trying again as an attachment...

>
> Cheers,
>
> Alex
>
> > ---
> > man7/vdso.7 | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/man7/vdso.7 b/man7/vdso.7
> > index fabb34d0d..9f47efc7d 100644
> > --- a/man7/vdso.7
> > +++ b/man7/vdso.7
> > @@ -459,12 +459,12 @@ The table below lists the symbols exported by the vDSO.
> > l l.
> > symbol version
> > _
> > -__kernel_rt_sigreturn LINUX_4.15
> > -__kernel_gettimeofday LINUX_4.15
> > -__kernel_clock_gettime LINUX_4.15
> > -__kernel_clock_getres LINUX_4.15
> > -__kernel_getcpu LINUX_4.15
> > -__kernel_flush_icache LINUX_4.15
> > +__vdso_rt_sigreturn LINUX_4.15
> > +__vdso_gettimeofday LINUX_4.15
> > +__vdso_clock_gettime LINUX_4.15
> > +__vdso_clock_getres LINUX_4.15
> > +__vdso_getcpu LINUX_4.15
> > +__vdso_flush_icache LINUX_4.15
> > .TE
> > .if t \{\
> > .in
>
> --
> <http://www.alejandro-colomar.es/>

[-- Attachment #2: 0001-vdso.7-fix-risc-v-symbol-names.patch --]
[-- Type: application/octet-stream, Size: 1238 bytes --]

From dd8bb709e65c9c3225b1a9e68963ac6f7ec89201 Mon Sep 17 00:00:00 2001
From: Elliott Hughes <enh@google.com>
Date: Mon, 30 Jan 2023 21:46:09 +0000
Subject: [PATCH] vdso.7: fix risc-v symbol names.

The kernel git history says the names have always been "__vdso_" rather
than "__kernel_", so I assume this was a copy & paste mistake from a
different architecture.

Luckily, the path to the kernel source that lets you confirm/deny this
_is_ correct :-)

Signed-off-by: Elliott Hughes <enh@google.com>

---
man7/vdso.7 | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/man7/vdso.7 b/man7/vdso.7
index fabb34d0d..9f47efc7d 100644
--- a/man7/vdso.7
+++ b/man7/vdso.7
@@ -459,12 +459,12 @@ The table below lists the symbols exported by the vDSO.
l l.
symbol version
_
-__kernel_rt_sigreturn LINUX_4.15
-__kernel_gettimeofday LINUX_4.15
-__kernel_clock_gettime LINUX_4.15
-__kernel_clock_getres LINUX_4.15
-__kernel_getcpu LINUX_4.15
-__kernel_flush_icache LINUX_4.15
+__vdso_rt_sigreturn LINUX_4.15
+__vdso_gettimeofday LINUX_4.15
+__vdso_clock_gettime LINUX_4.15
+__vdso_clock_getres LINUX_4.15
+__vdso_getcpu LINUX_4.15
+__vdso_flush_icache LINUX_4.15
.TE
.if t \{\
.in
--
2.39.1.456.gfc5497dd1b-goog