public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: linux-man <linux-man@vger.kernel.org>
Subject: Makefile: Use standard variables and locations
Date: Sat, 20 Mar 2021 22:03:14 +0100	[thread overview]
Message-ID: <b4cf925a-ac73-33bd-a6eb-514c69e82d51@gmail.com> (raw)

Hi Michael,

There are a few points I think we should fix in the Makefile:

- Use standard variables:
	* mandir (instead of MANDIR)
	* htmldir (instead of HTDIR)
	(see
<https://www.gnu.org/software/make/manual/html_node/Directory-Variables.html>)

- Use standard targets:
	* separate html into html and install-html
	* installdirs (instead of having 'mkdir -p'/'install -d' embedded in
targets)
	(see
<https://www.gnu.org/software/make/manual/html_node/Standard-Targets.html#Standard-Targets>)

- '?=' is not needed, I think.  When a user defines a variable in the
command line, that overwrites any definition in the Makefile.

- Is '|| exit $$?' really needed?  AFAIK, make exits on error.  Maybe
there's a corner case that make doesn't handle well and exit does,
though.  I don't know.

- Use $(INSTALL_DATA) instead of using install directly.

- Specify SHELL = /bin/sh


Any thoughts?

Cheers,

Alex

-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

             reply	other threads:[~2021-03-20 21:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-20 21:03 Alejandro Colomar (man-pages) [this message]
2021-03-25 22:06 ` Makefile: Use standard variables and locations Jakub Wilk
2021-03-28 11:57   ` Alejandro Colomar (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4cf925a-ac73-33bd-a6eb-514c69e82d51@gmail.com \
    --to=alx.manpages@gmail.com \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox