public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Alejandro Colomar <alx.manpages@gmail.com>
Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org
Subject: Re: [PATCH] tkill.2: SYNOPSIS: Fix prototype parameter types
Date: Mon, 15 Feb 2021 21:01:02 +0100	[thread overview]
Message-ID: <b96a993d-3012-f5ad-1d32-657ed2364efd@gmail.com> (raw)
In-Reply-To: <20210215131522.450666-8-alx.manpages@gmail.com>

Hi Alex,

On 2/15/21 2:15 PM, Alejandro Colomar wrote:
> All but the last parameters of t[g]kill() use 'pid_t',
> both in the kernel and glibc.  Fix them.
> 
> ......
> 
> .../linux/linux$ grep_syscall tkill
> kernel/signal.c:3870:
> SYSCALL_DEFINE2(tkill, pid_t, pid, int, sig)
> include/linux/syscalls.h:685:
> asmlinkage long sys_tkill(pid_t pid, int sig);
> .../linux/linux$
> 
> .../gnu/glibc$ grep_glibc_prototype tgkill
> sysdeps/unix/sysv/linux/bits/signal_ext.h:29:
> extern int tgkill (__pid_t __tgid, __pid_t __tid, int __signal);
> .../gnu/glibc$
> 
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>


Thanks! Patch applied.

Cheers,

Michael


> ---
>  man2/tkill.2 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/man2/tkill.2 b/man2/tkill.2
> index 4b4eae312..24636719d 100644
> --- a/man2/tkill.2
> +++ b/man2/tkill.2
> @@ -31,8 +31,8 @@
>  tkill, tgkill \- send a signal to a thread
>  .SH SYNOPSIS
>  .nf
> -.BI "int tkill(int " tid ", int " sig );
> -.BI "int tgkill(int " tgid ", int " tid ", int " sig );
> +.BI "int tkill(pid_t " tid ", int " sig );
> +.BI "int tgkill(pid_t " tgid ", pid_t " tid ", int " sig );
>  .fi
>  .PP
>  .IR Note :
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

      reply	other threads:[~2021-02-15 20:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15 13:15 [PATCH] tkill.2: SYNOPSIS: Fix prototype parameter types Alejandro Colomar
2021-02-15 20:01 ` Michael Kerrisk (man-pages) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b96a993d-3012-f5ad-1d32-657ed2364efd@gmail.com \
    --to=mtk.manpages@gmail.com \
    --cc=alx.manpages@gmail.com \
    --cc=linux-man@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox