Re: [PATCH] statx.2: Update STATX_WRITE_ATOMIC filesystem support

[John Garry <john.g.garry@oracle.com>]

On 05/12/2024 10:02, Alejandro Colomar wrote:
> Hi John,
> 
> On Thu, Dec 05, 2024 at 09:33:18AM +0000, John Garry wrote:
>> On 04/12/2024 20:45, Alejandro Colomar wrote:
>>> Hi John,
>>>
>>> On Tue, Dec 03, 2024 at 02:53:59PM +0000, John Garry wrote:
>>>> Linux v6.13 will
>>>
>>> Is this already in Linus's tree?
>>
>> The code to support xfs and ext4 is in Linus' tree from v6.13-rc1, but v6.13
>> final is not released yet.
>>
>> So maybe you want to hold off on this patch until v6.13 final is released.
> 
> Nah, we can apply it already.  Just let me know if anything changes
> before the release.

Hi Alex,

I'd suggest that it is ok to merge this now, but Branden seems to have 
comments...

> 
>>>> diff --git a/man/man2/statx.2 b/man/man2/statx.2
>>>> index c5b5a28ec..2d33998c5 100644
>>>> --- a/man/man2/statx.2
>>>> +++ b/man/man2/statx.2
>>>> @@ -482,6 +482,15 @@ The minimum and maximum sizes (in bytes) supported for direct I/O
>>>>    .RB ( O_DIRECT )
>>>>    on the file to be written with torn-write protection.
>>>>    These values are each guaranteed to be a power-of-2.
>>>> +.IP
>>>> +.B STATX_WRITE_ATOMIC
>>>> +.RI ( stx_atomic_write_unit_min,
>>>> +.RI stx_atomic_write_unit_max,
>>>
>>> There should be a space before the ','.
>>>
>>>> +and
>>>> +.IR stx_atomic_write_segments_max )
>>
>> How about this:
>>
>> .B STATX_WRITE_ATOMIC
>> .RI ( stx_atomic_write_unit_min,
>> .I stx_atomic_write_unit_max,
>> and
>> .IR stx_atomic_write_segments_max )
>>
>> I think that this looks right.
> 
> No; the comma shouldn't be in italics.


Please fix up as you see fit.

> 
> .B STATX_WRITE_ATOMIC
> .RI ( stx_atomic_write_unit_min ,
> .IR stx_atomic_write_unit_max ,
> and
> .IR stx_atomic_write_segments_max )
>


Thanks,
John