Re: [PATCH 1/2] ioctl_userfaultfd.2: add UFFD_FEATURE_WP_ASYNC

[Muhammad Usama Anjum <usama.anjum@collabora.com>]

Hi Alex,

Thank you so much for reviewing.

On 10/17/23 9:41 PM, Alejandro Colomar wrote:
> Hi Muhammad,
> 
> On Tue, Oct 17, 2023 at 08:01:31PM +0500, Muhammad Usama Anjum wrote:
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>> ---
>>  man2/ioctl_userfaultfd.2 | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2
>> index e68085262..cdf90882a 100644
>> --- a/man2/ioctl_userfaultfd.2
>> +++ b/man2/ioctl_userfaultfd.2
>> @@ -244,6 +244,11 @@ If this feature bit is set,
>>  the kernel supports resolving faults with the
>>  .B UFFDIO_POISON
>>  ioctl.
>> +.TP
>> +.BR UFFD_FEATURE_WP_ASYNC " (since Linux 6.7)"
>> +If this feature bit is set,
>> +the write protection faults would be asynchronously resolved by the
> 
> Please use semantic newlines.  See man-pages(7):
Okay. I'll break this line before "by".

> 
> $ MANWIDTH=72 man man-pages | sed -n '/Use semantic newlines/,/^$/p'
>    Use semantic newlines
>        In the source of a manual page, new sentences should be started
>        on  new  lines,  long  sentences  should be split into lines at
>        clause breaks (commas, semicolons, colons, and so on), and long
>        clauses should be split at phrase boundaries.  This convention,
>        sometimes known as "semantic newlines", makes it easier to  see
>        the  effect of patches, which often operate at the level of in‐
>        dividual sentences, clauses, or phrases.
> 
> Thanks,
> Alex
> 
>> +kernel.
>>  .PP
>>  The returned
>>  .I ioctls
>> -- 
>> 2.40.1
>>
> 

-- 
BR,
Muhammad Usama Anjum