From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF7DFCDB465 for ; Thu, 19 Oct 2023 07:26:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232810AbjJSH0W (ORCPT ); Thu, 19 Oct 2023 03:26:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232326AbjJSH0V (ORCPT ); Thu, 19 Oct 2023 03:26:21 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0ADDE9F for ; Thu, 19 Oct 2023 00:26:20 -0700 (PDT) Received: from [192.168.10.2] (unknown [39.45.48.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 2730E6607319; Thu, 19 Oct 2023 08:26:16 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1697700378; bh=YBHbMTXbI0AianywYsCfI/KWRXqvxJGpVAL0KEf2SHo=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=aejuH5dtfHS8ZAXdjLsrt9iWvBe6tnOiTfiUKJUpqcUN/Grmv8l7lO+j2fLgSHjEE 1uSEKZtVZ14AJulaumQeEy5RC+C8J/YNPU9PXN7D7DSMgqf9Sjp4x0zqXdbfotDFMA qOKqqXgc2cA/8EC38aFWpYpgWPo1Llrl0GMflj8vbmoWvMqZQvN9qvIlefmo3ysF0g xcXnKV20jKWKeJkZCBg8lgBViSDEQeYe9dNx+v9etUUSTVeV4WcL4H2gQc5YFyOF6K Ne1qoCCLsc9hQk+ddHA4zDYLOzLI+cVhyPDqj+LGqlk3KDgMH3fHKfSTW4WQkt1R0b klilwCEvSnh5w== Message-ID: Date: Thu, 19 Oct 2023 12:26:11 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , kernel@collabora.com, linux-man@vger.kernel.org Subject: Re: [PATCH 1/2] ioctl_userfaultfd.2: add UFFD_FEATURE_WP_ASYNC Content-Language: en-US To: Alejandro Colomar References: <20231017150138.3406580-1-usama.anjum@collabora.com> From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org Hi Alex, Thank you so much for reviewing. On 10/17/23 9:41 PM, Alejandro Colomar wrote: > Hi Muhammad, > > On Tue, Oct 17, 2023 at 08:01:31PM +0500, Muhammad Usama Anjum wrote: >> Signed-off-by: Muhammad Usama Anjum >> --- >> man2/ioctl_userfaultfd.2 | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2 >> index e68085262..cdf90882a 100644 >> --- a/man2/ioctl_userfaultfd.2 >> +++ b/man2/ioctl_userfaultfd.2 >> @@ -244,6 +244,11 @@ If this feature bit is set, >> the kernel supports resolving faults with the >> .B UFFDIO_POISON >> ioctl. >> +.TP >> +.BR UFFD_FEATURE_WP_ASYNC " (since Linux 6.7)" >> +If this feature bit is set, >> +the write protection faults would be asynchronously resolved by the > > Please use semantic newlines. See man-pages(7): Okay. I'll break this line before "by". > > $ MANWIDTH=72 man man-pages | sed -n '/Use semantic newlines/,/^$/p' > Use semantic newlines > In the source of a manual page, new sentences should be started > on new lines, long sentences should be split into lines at > clause breaks (commas, semicolons, colons, and so on), and long > clauses should be split at phrase boundaries. This convention, > sometimes known as "semantic newlines", makes it easier to see > the effect of patches, which often operate at the level of in‐ > dividual sentences, clauses, or phrases. > > Thanks, > Alex > >> +kernel. >> .PP >> The returned >> .I ioctls >> -- >> 2.40.1 >> > -- BR, Muhammad Usama Anjum