[Bug 103701] New: timegm() manpage suggests a terrible workaround

[Bug 103701] New: timegm() manpage suggests a terrible workaround

[bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r]

https://bugzilla.kernel.org/show_bug.cgi?id=103701

            Bug ID: 103701
           Summary: timegm() manpage suggests a terrible workaround
           Product: Documentation
           Version: unspecified
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: low
          Priority: P1
         Component: man-pages
          Assignee: documentation_man-pages-ztI5WcYan/vQLgFONoPN62D2FQJk+8+b@public.gmane.org
          Reporter: shurd-f8dUBLffeLvR7s880joybQ@public.gmane.org
        Regression: No

In today's multi-threaded world, is changing an environment variable, calling
tzset(), calling mktime(), changing the env variable back, and calling tzset()
again really the best way to solve this problem?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Bug 103701] timegm() manpage suggests a terrible workaround

[bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r]

https://bugzilla.kernel.org/show_bug.cgi?id=103701

Michael Kerrisk <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

--- Comment #1 from Michael Kerrisk <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ---
Stephen,

It's obviously not ideal. I added some words pointing out that it's not
thread-safe. But, I have no further idea for changes. Do you?

Cheers,

Michael

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Bug 103701] timegm() manpage suggests a terrible workaround

[bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r]

https://bugzilla.kernel.org/show_bug.cgi?id=103701

--- Comment #2 from Stephen Hurd <shurd-f8dUBLffeLvR7s880joybQ@public.gmane.org> ---
I'm not sure why the manpage documents how to not use the function (obviously,
documenting *why* not to use it makes sense.)

If there's honestly no good way to emulate timegm() in a threadsafe manner,
should its use really be discouraged?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Bug 103701] timegm() manpage suggests a terrible workaround

[bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r]

https://bugzilla.kernel.org/show_bug.cgi?id=103701

Mats Wichmann <mats-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mats-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org

--- Comment #3 from Mats Wichmann <mats-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org> ---
The Gnu glibc documentation has something like this in the portability notes. 
Often the genesis of comments when there's a strange disclaimer in the manpage
:)

I guess I'd suggest the page emphasize the UTC aspect and mention the
threadsafe issue, and stop there - not try to document a workaround.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Bug 103701] timegm() manpage suggests a terrible workaround

[bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r]

https://bugzilla.kernel.org/show_bug.cgi?id=103701

Michael Kerrisk <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

--- Comment #4 from Michael Kerrisk <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ---
Okay--you two convinced me. I killed the sample timegm() implementation and
added mention of UTC. Thread-safety issues are covered already in ATTRIBUTES.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html