From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Alejandro Colomar <colomar.6.4.3@gmail.com>
Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org
Subject: Re: [PATCH 35/35] qsort.3: Use sizeof consistently
Date: Sat, 5 Sep 2020 17:27:21 +0200 [thread overview]
Message-ID: <c5bde196-b3a0-10dc-1404-0c46fee14a8d@gmail.com> (raw)
In-Reply-To: <20200905142037.522910-1-colomar.6.4.3@gmail.com>
On 9/5/20 4:20 PM, Alejandro Colomar wrote:
> Use ``sizeof`` consistently through all the examples in the following
> way:
>
> - Use the name of the variable instead of its type as argument for
> ``sizeof``.
>
> Rationale:
> https://www.kernel.org/doc/html/v5.8/process/coding-style.html#allocating-memory
>
> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
I'm not convinced about this one. Do you really think it
improves readability? I kinda feel that it does not.
Thanks,
Michael
> ---
> man3/qsort.3 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man3/qsort.3 b/man3/qsort.3
> index b49c2a9d3..e1af43cf0 100644
> --- a/man3/qsort.3
> +++ b/man3/qsort.3
> @@ -150,7 +150,7 @@ main(int argc, char *argv[])
> exit(EXIT_FAILURE);
> }
>
> - qsort(&argv[1], argc \- 1, sizeof(char *), cmpstringp);
> + qsort(&argv[1], argc \- 1, sizeof(argv[0]), cmpstringp);
>
> for (j = 1; j < argc; j++)
> puts(argv[j]);
>
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2020-09-05 15:27 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 13:29 [patch] memusage.1, bind.2, eventfd.2, futex.2, open_by_handle_at.2, perf_event_open.2, poll.2, signalfd.2, sysctl.2, timerfd_create.2, bsearch.3, cmsg.3, getaddrinfo.3, getaddrinfo_a.3 getgrouplist.3, insque.3, malloc_info.3, mbsinit.3, mbstowcs.3, pthread_create.3, pthread_setaffinity_np.3, queue.3, rtnetlink.3, shm_open.3, strptime.3, tsearch.3, aio.7, fanotify.7, inotify.7, unix.7: Use sizeof consistently Alejandro Colomar
2020-08-25 10:29 ` Michael Kerrisk (man-pages)
2020-08-25 11:19 ` Jakub Wilk
2020-08-25 11:34 ` Alejandro Colomar
2020-08-25 11:41 ` Michael Kerrisk (man-pages)
2020-08-25 11:48 ` Alejandro Colomar
2020-08-25 12:21 ` Alejandro Colomar
2020-08-25 12:35 ` Michael Kerrisk (man-pages)
2020-08-25 13:05 ` [PATCH] cmsg.3, getaddrinfo_a.3 getgrouplist.3: Use sizeof, consistently Alejandro Colomar
2020-08-26 6:21 ` Michael Kerrisk (man-pages)
2020-09-03 10:23 ` [PATCH] memusage.1: Use sizeof consistently Alejandro Colomar
2020-09-04 8:20 ` Michael Kerrisk (man-pages)
2020-09-04 10:19 ` [PATCH (2) 02/34] bind.2: " Alejandro Colomar
2020-09-04 10:21 ` [PATCH (2) 03/34] eventfd.2: " Alejandro Colomar
2020-09-04 10:46 ` Michael Kerrisk (man-pages)
2020-09-04 10:54 ` [PATCH (2) 04/34] futex.2: " Alejandro Colomar
2020-09-04 10:55 ` [PATCH (2) 05/34] open_by_handle_at.2: " Alejandro Colomar
2020-09-04 10:56 ` [PATCH (2) 06/34] perf_event_open.2: " Alejandro Colomar
2020-09-04 10:57 ` [PATCH (2) 07/34] " Alejandro Colomar
2020-09-04 12:25 ` Michael Kerrisk (man-pages)
2020-09-04 13:42 ` [PATCH (2) 08/34] poll.2: " Alejandro Colomar
2020-09-04 13:43 ` [PATCH (2) 09/34] sysctl.2: " Alejandro Colomar
2020-09-04 13:44 ` [PATCH (2) 10/34] signalfd.2: " Alejandro Colomar
2020-09-04 13:45 ` [PATCH (2) 11/34] timerfd_create.2: " Alejandro Colomar
2020-09-04 13:46 ` [PATCH (2) 12/34] bsearch.3: " Alejandro Colomar
2020-09-04 13:50 ` [PATCH (2) 13/34] cmsg.3: " Alejandro Colomar
2020-09-04 13:52 ` [PATCH (2) 14/34] " Alejandro Colomar
2020-09-04 13:53 ` [PATCH (2) 15/34] getaddrinfo.3: " Alejandro Colomar
2020-09-04 14:32 ` [PATCH (2) 16/34] " Alejandro Colomar
2020-09-04 14:34 ` [PATCH (2) 17/34] getgrouplist.3: " Alejandro Colomar
2020-09-04 14:37 ` [PATCH (2) 18/34] insque.3: " Alejandro Colomar
2020-09-04 14:41 ` [PATCH (2) 19/34] malloc_info.3: " Alejandro Colomar
2020-09-04 14:44 ` [PATCH (2) 20/34] mbsinit.3: " Alejandro Colomar
2020-09-04 14:45 ` [PATCH (2) 21/34] mbstowcs.3: " Alejandro Colomar
2020-09-04 14:48 ` [PATCH (2) 22/34] pthread_create.3: " Alejandro Colomar
2020-09-04 14:50 ` [PATCH (2) 23/34] pthread_setaffinity_np.3: " Alejandro Colomar
2020-09-04 14:50 ` [PATCH (2) 24/34] queue.3: " Alejandro Colomar
2020-09-04 14:52 ` [PATCH (2) 25/34] rtnetlink.3: " Alejandro Colomar
2020-09-04 14:54 ` [PATCH (2) 26/34] " Alejandro Colomar
2020-09-04 14:55 ` [PATCH (2) 27/34] shm_open.3: " Alejandro Colomar
2020-09-04 14:57 ` [PATCH (2) 28/34] strptime.3: " Alejandro Colomar
2020-09-04 15:37 ` Michael Kerrisk (man-pages)
2020-09-04 15:03 ` [PATCH (2) 29/34] tsearch.3: " Alejandro Colomar
2020-09-05 14:22 ` Michael Kerrisk (man-pages)
2020-09-04 15:04 ` [PATCH (2) 30/34] aio.7: " Alejandro Colomar
2020-09-04 17:15 ` Michael Kerrisk (man-pages)
2020-09-04 15:05 ` [PATCH (2) 31/34] fanotify.7: " Alejandro Colomar
2020-09-04 15:38 ` Michael Kerrisk (man-pages)
2020-09-04 15:06 ` [PATCH (2) 32/34] inotify.7: " Alejandro Colomar
2020-09-04 17:08 ` Michael Kerrisk (man-pages)
2020-09-04 15:07 ` [PATCH (2) 33/34] " Alejandro Colomar
2020-09-04 17:14 ` Michael Kerrisk (man-pages)
2020-09-04 15:08 ` [PATCH (2) 34/34] unix.7: " Alejandro Colomar
2020-09-04 15:12 ` Alejandro Colomar
2020-09-05 8:27 ` Michael Kerrisk (man-pages)
2020-09-05 9:37 ` Alejandro Colomar
2020-09-05 14:38 ` Michael Kerrisk (man-pages)
2020-09-05 14:52 ` Alejandro Colomar
2020-09-05 15:24 ` Michael Kerrisk (man-pages)
2020-09-04 15:40 ` Michael Kerrisk (man-pages)
2020-09-04 17:26 ` [PATCH (2) 27/34] shm_open.3: " Michael Kerrisk (man-pages)
2020-09-04 17:04 ` [PATCH (2) 26/34] rtnetlink.3: " Michael Kerrisk (man-pages)
2020-09-04 16:59 ` [PATCH (2) 25/34] " Michael Kerrisk (man-pages)
2020-09-04 16:58 ` [PATCH (2) 24/34] queue.3: " Michael Kerrisk (man-pages)
2020-09-04 15:42 ` [PATCH (2) 23/34] pthread_setaffinity_np.3: " Michael Kerrisk (man-pages)
2020-09-05 14:21 ` [PATCH (2) 22/34] pthread_create.3: " Michael Kerrisk (man-pages)
2020-09-05 14:21 ` [PATCH (2) 21/34] mbstowcs.3: " Michael Kerrisk (man-pages)
2020-09-04 15:27 ` [PATCH (2) 20/34] mbsinit.3: " Michael Kerrisk (man-pages)
2020-09-04 15:27 ` [PATCH (2) 19/34] malloc_info.3: " Michael Kerrisk (man-pages)
2020-09-04 15:25 ` [PATCH (2) 18/34] insque.3: " Michael Kerrisk (man-pages)
2020-09-04 15:25 ` [PATCH (2) 17/34] getgrouplist.3: " Michael Kerrisk (man-pages)
2020-09-04 15:21 ` [PATCH (2) 16/34] getaddrinfo.3: " Michael Kerrisk (man-pages)
2020-09-04 15:20 ` [PATCH (2) 15/34] " Michael Kerrisk (man-pages)
2020-09-04 13:54 ` Alejandro Colomar
2020-09-04 15:20 ` [PATCH (2) 14/34] cmsg.3: " Michael Kerrisk (man-pages)
2020-09-04 15:18 ` [PATCH (2) 13/34] " Michael Kerrisk (man-pages)
2020-09-04 15:17 ` [PATCH (2) 12/34] bsearch.3: " Michael Kerrisk (man-pages)
2020-09-04 15:14 ` [PATCH (2) 11/34] timerfd_create.2: " Michael Kerrisk (man-pages)
2020-09-05 8:07 ` Michael Kerrisk (man-pages)
2020-09-04 15:13 ` [PATCH (2) 10/34] signalfd.2: " Michael Kerrisk (man-pages)
2020-09-04 15:11 ` [PATCH (2) 09/34] sysctl.2: " Michael Kerrisk (man-pages)
2020-09-04 15:11 ` [PATCH (2) 08/34] poll.2: " Michael Kerrisk (man-pages)
2020-09-04 12:24 ` [PATCH (2) 06/34] perf_event_open.2: " Michael Kerrisk (man-pages)
2020-09-04 12:20 ` [PATCH (2) 05/34] open_by_handle_at.2: " Michael Kerrisk (man-pages)
2020-09-04 12:19 ` [PATCH (2) 04/34] futex.2: " Michael Kerrisk (man-pages)
2020-09-04 10:44 ` [PATCH (2) 02/34] bind.2: " Michael Kerrisk (man-pages)
2020-08-25 11:35 ` [patch] memusage.1, bind.2, eventfd.2, futex.2, open_by_handle_at.2, perf_event_open.2, poll.2, signalfd.2, sysctl.2, timerfd_create.2, bsearch.3, cmsg.3, getaddrinfo.3, getaddrinfo_a.3 getgrouplist.3, insque.3, malloc_info.3, mbsinit.3, mbstowcs.3, pthread_create.3, pthread_setaffinity_np.3, queue.3, rtnetlink.3, shm_open.3, strptime.3, tsearch.3, aio.7, fanotify.7, inotify.7, unix.7: " Michael Kerrisk (man-pages)
2020-09-05 14:20 ` [PATCH 35/35] qsort.3: " Alejandro Colomar
2020-09-05 14:23 ` Alejandro Colomar
2020-09-05 15:27 ` Michael Kerrisk (man-pages) [this message]
2020-09-05 15:32 ` Alejandro Colomar
2020-09-05 15:36 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5bde196-b3a0-10dc-1404-0c46fee14a8d@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=colomar.6.4.3@gmail.com \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox