From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: linux-man@vger.kernel.org
Subject: Re: [PATCH v5] prctl.2: Document Syscall User Dispatch
Date: Mon, 28 Dec 2020 19:24:39 +0100 [thread overview]
Message-ID: <c73ca93d-b723-adc1-0603-4c7f9ecc458e@gmail.com> (raw)
In-Reply-To: <85b23b60-a92c-a5a8-1cc5-24bdfb8b3530@gmail.com>
Hi Michael & Gabriel,
I disagree on a comment; see below.
On 12/24/20 10:18 AM, Michael Kerrisk (man-pages) wrote:
> Hello Gabriel,
>
> Thanks for the revisions!
>
[...]
>> +.IP
>> +When
>> +.I arg2
>> +is set to
>> +.BR PR_SYS_DISPATCH_ON ,
>> +.I arg3
>> +and
>> +.I arg4
>> +respectively identify the
>> +.I offset
>> +and
>> +.I length
>> +of a single contiguous memory region in the process map
>> +from where system calls are always allowed to be executed,
>> +regardless of the switch variable
>> +(Typically, this area would include the area of memory
>> +containing the C library).
>
> s/)./.)/
That point is ending the full sentence starting at 'When', not just the
sentence in parentheses.
See <https://www.thepunctuationguide.com/terminal-points.html>.
Quoting that, "The main sentence takes a period outside the closing
parenthesis no matter what punctuation is included inside the
parenthetical element.". So that you should be able to: s/(.*)//
s/)./.)./ would be more correct, but I think ').' is enough.
See my quotation above, which is a similar example :)
I'd also s/Typically/typically/
Your thoughts?
Thanks,
Alex
>
>> +.I arg5
>> +points to a char-sized variable
>> +that is a fast switch to enable/disable the mechanism
>> +without the overhead of doing a system call.
>> +The variable pointed by
--
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/
next prev parent reply other threads:[~2020-12-28 18:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 18:29 [PATCH v5] prctl.2: Document Syscall User Dispatch Gabriel Krisman Bertazi
2020-12-24 9:18 ` Michael Kerrisk (man-pages)
2020-12-28 18:24 ` Alejandro Colomar (man-pages) [this message]
2020-12-28 20:06 ` Michael Kerrisk (man-pages)
2020-12-28 20:41 ` Alejandro Colomar (man-pages)
2020-12-28 20:53 ` Michael Kerrisk (man-pages)
2020-12-28 21:08 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c73ca93d-b723-adc1-0603-4c7f9ecc458e@gmail.com \
--to=alx.manpages@gmail.com \
--cc=krisman@collabora.com \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox