Re: [PATCH] string_copying.7: tfix

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1507 bytes --]

On 2023-07-29 01:26, Lennart Jablonka wrote:

[...]

>>> @@ -444,8 +444,8 @@ is a more useful alternative to this function.
>>>  .\" ----- DESCRIPTION :: Functions :: zustr2ustp(3) --------------------/
>>>  .TP
>>>  .BR zustr2ustp (3)
>>> -This function copies the input character sequence
>>> -contained in a null-padded wixed-width buffer,
>>> +This function copies the input character sequence,
>>
>> I believe the below is like a parenthetical, which is why I put it
>> between commas; isn't it?  Although your version also looks good.
>>
>>> +contained in a null-padded fixed-width buffer,
>>
>> Ok
>>
>>>  into a destination character sequence.
> 
> The “contained in a null-padded fixed-width buffer” indeed looks 
> like a parenthetical (or rather, a non-restrictive participial 
> clause—the “contained” is the participle), which is why it should 
> be between commas.  You didn’t do quite that:  You put a comma 
> after it, but not before.
> 
> This case is what I tried to explain:  You set off the “into 
> a destination character sequence” prepositional phrase (the “into” 
> being the preposition) by a comma.  You did not surround the 
> participial clause by commas.  That’s what I did.

D'oh!  I misread the diff; I thought you were removing the comma
instead of adding it.  I certainly like your addition.

Cheers,
Alex

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]