Re: [PATCH 03/23] sigaction.2: Apply minor tweaks to Peter's patch

Alejandro Colomar (man-pages)
2021-08-09T06:36:46Z

Hi Michael,

On 8/9/21 2:34 AM, Michael Kerrisk (man-pages) wrote:
> Hi Alex,
>
> On 8/8/21 10:41 AM, Alejandro Colomar wrote:
>> - Move example program to a new EXAMPLES section
>
> Not a big thing, but perhaps it would have been nicer to have
> two patches, the first doing the pieces below, and the second
> doing the step above. That would enable me to more easily see
> what changes you made below. But, I am not sure; maybe that
> is more work than is justified...

If you haven't pushed yet, you can drop it and I'll break it into two :)

Not so much work: I could write a commit with a simple move, and then
checkout the file from the old commit, and commit the difference into a
second commit.

But I see you already pushed.

> All looks good. I also had some additional fixes (2 patches). See below.

Those 2 look good to me too.

Cheers,

Alex

--
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/