Re: [PATCH] execveat.2: srcfix

Alejandro Colomar (man-pages)
2021-01-02T21:41:25Z

Hi Michael,

I read everything this time ;)

On 1/2/21 8:59 PM, Michael Kerrisk (man-pages) wrote:
> HI Alex,
>
> On Sat, 2 Jan 2021 at 17:04, Alejandro Colomar (man-pages)
> <alx.manpages@gmail.com> wrote:
>>
>> Hi Michael,
>>
>> On 1/1/21 11:29 PM, Michael Kerrisk (man-pages) wrote:
>>> Hi Alex,
>> [...]>>>> login.3: group
>>>>
>>>> ffix!!
>>>
>>> Done.
>>>
>>>> The following may help:
>>>>
>>>> $ for p in $(git grep -l '.SH SYN' man?); do \
>>>> echo "===================== $p"; \
>>>> man -l $p 2> /dev/null \
>>>> |sed -n '/^SYNOP/,/DESCR/p' \
>>>> |sed '/Feat/,$d'; \
>>>> done \
>>>> |grep '); *[a-zA-Z_]' \
>>>> |grep -v -e 'Note:' -e NOTES;
>>>> int brk(void *addr); void *sbrk(intptr_t increment);
>>>> set); ssize_t pwrite(int fd, const void *buf, size_t
>>>> long a64l(const char *str64); char *l64a(long value);
>>>> double fmax(double x, double y); float fmaxf(float x,
>>>> float y); long double fmaxl(long double x, long double
>>>> void login(const struct utmp *ut); int logout(const char
>>>> place the result(s); inproc is used to encode the
>>>> dress of where to place the result(s); inproc is
>>>> ter(s); procname should return a pointer to its
>>>> static result(s); inproc is used to decode the pa‐
>>>> RPC socket(s); rdfds is the resultant read file
>>>> int wordexp(const char *s, wordexp_t *p, int flags); void
>>>> sp,MAXUN.UNSIGNED ); where MAXUN.UNSIGNED is the
>>>> (SIGEV_THREAD_ID); Linux-specific */
>>>
>>> Thanks. I fixed a few things.
>>>
>>
>> wordexp.3 is still broken.
>
> Thanks. Fixed now.
>
>>>>>> I didn't read past that.
>>>>
>>>> Still I didn't read past that :)
>>
>> Later I'll have a look past there :)
>
> That would be great!

adjtimex.2: compact
getpeername.2: 78-col
kexec_load.2: compact?
msgop.2: compact
rt_sigqueueinfo.2: Join + compact
sgetmask.2: compact
subpage_prot.2: Join
vm86.2: compact

circleq.3, list.3, slist.3, tailq.3, stailq.3: group?
des_crypt.3: group
drand48_r.3: Join
error.3: group
ether_aton.3: group
exec.3: consistency with commas; execvpe can be joined
fseeko.3: compact

resolver.3: group?
rewinddir.3: compact headers
rpc: 78-col
CLGET_SERVER_ADDR struct sockaddr_in // get server's addre
ss
rtnetlink.3: group or compact; 78-col
scandir.3:
scandir(): move 'filter' and 'compar' 1 char to the right
so that parentheses are not aligned and confuse.
It still fits 1 char to the right but not to for a 78-col.
group?
scandirat(): ffix!!: namelist can be joined
setaliasent.3: move more to the right
shm_open.3: compact
sigpause.3: compact
sigset.3: group
strstr.3: compact #define & #include
termios.3: group even more?
timegm.3: compact
unlocked_stdio.3: Join fread_unlocked(3)? Or not?
xdr.3: wsfix: g/) (/s//)(/
(See if there are any other pages with this
that I may haven't seen.)

man.7: group or compact
rtnetlink.7: 78-col
sigevent.7: s/) (/)(/
If you move the comments a few chars to the right (3<=x<=6),
you will compact one line

Also, curiously execveat(2), which is the one that started all this,
didn't look bad :p
So we'll have to grep for .nf/.fi too after this.

Things to note for other patches:

isw*.3: Rewrite into one page similar to isalpha.3?
Does it really need so many pages?
recno.3: Review: no APIs
string.3: What is the criterion for functions to be there?
Also, there are functions which are already documented
in their own pages (see strcpy(3))
Some others don't appear there (see memcpy(3)
eventhough they are in string.h.

Cheers,

Alex

>
> Cheers,
>
> Michael
>

--
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/