Re: [PATCH] recv.2: msg_iovec / MSG_ERRQUEUE / -v

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 2603 bytes --]

Hi Rob, Branden!

On 2023-07-12 11:05, Rob Linden wrote:
> Hello Alejandro!
> 
> This is a combined repost of the 3 individual patches I sent in June.

Thanks!

>  (I
> had thought it makes sense to split it up, because the changes were
> unrelated, so maybe one could be approved while another one needs
> discussion).

Yup, normally, I prefer them separate, but if they are somewhat related,
I prefer a set of mails, so that subsequent patch mails appear as replies
to the first mail.  Also, since I was away for a long time, my mailbox
was a bit messy.

Basically:
	git format-patch master..HEAD -v2 ...


> 
> I think there is a mistake on the manpage for recv.  In the description of
> the flag MSG_ERRQUEUE it says that data is passed via "msg_iovec".  This is
> probably referring to msg_iov in struct msghdr (from
> /usr/include/bits/socket.h).  A "msg_iovec" doesn't seem to exist.  Maybe it
> was spelled wrong because it's of type struct iovec.  If it is indeed wrong
> then the following patch corrects it.

This sounds reasonable to me.  Please include it in the commit message.

> 
> I think the flag MSG_ERRQUEUE, that is described on the man page recv.2 is
> only applicable to recvmsg, and not recv or recvfrom.  Maybe it would be
> good to mention it, just like it is specified for MSG_CMSG_CLOEXEC.  The
> following patch does that.

This seems reasonable, but could you please provide something a bit more
tangible than "I think"?  Some kernel documentation?  Some test program?
(A test program would be excellent even if you have something else.)
Another reason?

> 
> While reading the recv manpage I came up with some suggestions which I
> believe would make it easier for the reader.  They are not corrections
> (except for the last block, which I believe was incomplete), just
> improvements (IMHO).

Please also include this in the third commit message.

> 
> Thanks & all the best,
> rob
> 
> 
> From 830a1b1233eb69bd8a4a64296581d094fb0edc46 Mon Sep 17 00:00:00 2001
> From: rokkbert <rokkbert@gmail.com>

[...]

> +.BR MSG_ERRQUEUE " (" recvmsg "() only; since Linux 2.2)"

I believe it should be recvmsg()-only, since it's a compound adjective.
Branden, can you please confirm if I'm right?

[...]

This third patch doesn't apply cleanly.  Please check.  Also, please send
as separate mails that are in reply to a first one, as a patch email
series, instead of a single email.

Thanks,
Alex

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]