From: Alex Colomar <alx.manpages@gmail.com>
To: "Günther Noack" <gnoack3000@gmail.com>,
"Mickaël Salaün" <mic@digikod.net>,
"G. Branden Robinson" <g.branden.robinson@gmail.com>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>,
linux-man@vger.kernel.org, Groff <groff@gnu.org>
Subject: Re: [PATCH 2/3] landlock.7: Document Landlock ABI v2 (file reparenting; kernel 5.19)
Date: Sat, 25 Feb 2023 02:10:22 +0100 [thread overview]
Message-ID: <d6b21981-71bc-4906-2adf-79b00df38b73@gmail.com> (raw)
In-Reply-To: <Y/coag7XQRIRDK0h@galopp>
[-- Attachment #1.1: Type: text/plain, Size: 3963 bytes --]
Hi Branden,
On 2/23/23 09:48, Günther Noack wrote:
> On Wed, Feb 22, 2023 at 08:36:37AM +0100, Mickaël Salaün wrote:
>> On 2023-02-21T21:50:22.000+01:00, Günther Noack wrote:
>>> +The availability of individual Landlock features is versioned through
>>> +ABI levels:
>>> +.TS
>>> +box;
>>> +ntb| ntb| lbx
>>> +nt| nt| lbx.
>>> +ABI Kernel Newly introduced access rights
>>> +_ _ _
>>> +1 5.13 LANDLOCK_ACCESS_FS_EXECUTE
>>> +\^ \^ LANDLOCK_ACCESS_FS_WRITE_FILE
>>> +\^ \^ LANDLOCK_ACCESS_FS_READ_FILE
>>> +\^ \^ LANDLOCK_ACCESS_FS_READ_DIR
>>> +\^ \^ LANDLOCK_ACCESS_FS_REMOVE_DIR
>>> +\^ \^ LANDLOCK_ACCESS_FS_REMOVE_FILE
>>> +\^ \^ LANDLOCK_ACCESS_FS_MAKE_CHAR
>>> +\^ \^ LANDLOCK_ACCESS_FS_MAKE_DIR
>>> +\^ \^ LANDLOCK_ACCESS_FS_MAKE_REG
>>> +\^ \^ LANDLOCK_ACCESS_FS_MAKE_SOCK
>>> +\^ \^ LANDLOCK_ACCESS_FS_MAKE_FIFO
>>> +\^ \^ LANDLOCK_ACCESS_FS_MAKE_BLOCK
>>> +\^ \^ LANDLOCK_ACCESS_FS_MAKE_SYM
>>> +_ _ _
>>> +2 5.19 LANDLOCK_ACCESS_FS_REFER
>>> +.TE
>>> +.PP
>>
>> A line break would be nice here.
>
> Added. (Used .sp 1 for that, as it is already used in the
> mount_namespaces.7, ip.7 and other man pages.)
This sounds weird, but they are right that there seems to be a missing
blank line. Could you explain why it's happening? I'd expect the .PP
to separate paragraphs with a blank, right? I see:
The availability of individual Landlock features is versioned
through ABI levels:
┌────┬────────┬────────────────────────────────────────────────┐
│ABI │ Kernel │ Newly introduced access rights │
├────┼────────┼────────────────────────────────────────────────┤
│ 1 │ 5.13 │ LANDLOCK_ACCESS_FS_EXECUTE │
│ │ │ LANDLOCK_ACCESS_FS_WRITE_FILE │
│ │ │ LANDLOCK_ACCESS_FS_READ_FILE │
│ │ │ LANDLOCK_ACCESS_FS_READ_DIR │
│ │ │ LANDLOCK_ACCESS_FS_REMOVE_DIR │
│ │ │ LANDLOCK_ACCESS_FS_REMOVE_FILE │
│ │ │ LANDLOCK_ACCESS_FS_MAKE_CHAR │
│ │ │ LANDLOCK_ACCESS_FS_MAKE_DIR │
│ │ │ LANDLOCK_ACCESS_FS_MAKE_REG │
│ │ │ LANDLOCK_ACCESS_FS_MAKE_SOCK │
│ │ │ LANDLOCK_ACCESS_FS_MAKE_FIFO │
│ │ │ LANDLOCK_ACCESS_FS_MAKE_BLOCK │
│ │ │ LANDLOCK_ACCESS_FS_MAKE_SYM │
├────┼────────┼────────────────────────────────────────────────┤
│ 2 │ 5.19 │ LANDLOCK_ACCESS_FS_REFER │
└────┴────────┴────────────────────────────────────────────────┘
To query the running kernel's Landlock ABI level, programs may
pass the LANDLOCK_CREATE_RULESET_VERSION flag to landlock_cre‐
ate_ruleset(2).
Cheers,
Alex
>
>>> +To query the running kernel's Landlock ABI level, programs may pass
>>
>> s/level/version/
>
> Thanks, I'm removing the word "level" here.
--
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-02-25 1:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 20:50 [PATCH 1/3] landlock.7: Move the warning about missing features into the CAVEATS section Günther Noack
2023-02-21 20:50 ` [PATCH 2/3] landlock.7: Document Landlock ABI v2 (file reparenting; kernel 5.19) Günther Noack
2023-02-22 7:01 ` Mickaël Salaün
2023-02-23 8:39 ` Günther Noack
2023-02-22 7:36 ` Mickaël Salaün
2023-02-23 8:48 ` Günther Noack
2023-02-25 1:10 ` Alex Colomar [this message]
2023-02-25 1:19 ` G. Branden Robinson
2023-02-25 1:29 ` Alex Colomar
2023-02-28 19:46 ` Günther Noack
2023-02-25 1:06 ` Alex Colomar
2023-02-22 7:45 ` Mickaël Salaün
2023-02-23 9:18 ` Günther Noack
2023-02-24 23:21 ` Alex Colomar
2023-02-28 20:21 ` Günther Noack
2023-02-21 20:50 ` [PATCH 3/3] landlock.7: Document Landlock ABI v3 (file truncation; kernel 6.2) Günther Noack
2023-02-22 8:04 ` Mickaël Salaün
2023-02-23 9:24 ` Günther Noack
2023-02-24 23:31 ` Alex Colomar
2023-02-28 20:29 ` Günther Noack
2023-02-24 23:04 ` [PATCH 1/3] landlock.7: Move the warning about missing features into the CAVEATS section Alex Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6b21981-71bc-4906-2adf-79b00df38b73@gmail.com \
--to=alx.manpages@gmail.com \
--cc=g.branden.robinson@gmail.com \
--cc=gnoack3000@gmail.com \
--cc=groff@gnu.org \
--cc=linux-man@vger.kernel.org \
--cc=mic@digikod.net \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox