public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
To: "Pali Rohár" <pali@kernel.org>,
	linux-man@vger.kernel.org,
	"Michael Kerrisk" <mtk.manpages@gmail.com>
Subject: Re: [PATCH] termios.3: Add information how to set baudrate to any other value
Date: Fri, 30 Jul 2021 20:29:24 +0200	[thread overview]
Message-ID: <d8e81fd3-0a7d-8fc8-4d2f-863aec8f6f14@gmail.com> (raw)
In-Reply-To: <20210730153044.23673-1-pali@kernel.org>

Hi Pali,

On 7/30/21 5:30 PM, Pali Rohár wrote:
> Signed-off-by: Pali Rohár <pali@kernel.org>

Please see some comments below.

Thanks,

Alex

> ---
>   man3/termios.3 | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/man3/termios.3 b/man3/termios.3
> index b7cdec507524..4d4593a33c32 100644
> --- a/man3/termios.3
> +++ b/man3/termios.3
> @@ -967,6 +967,12 @@ Normally, this will disconnect the line.
>   \fBCBAUDEX\fP is a mask
>   for the speeds beyond those defined in POSIX.1 (57600 and above).
>   Thus, \fBB57600\fP & \fBCBAUDEX\fP is nonzero.

I think this should go on a separate paragraph, don't you?

.PP?

> +Setting baudrate to other value than defined by

wfix?:

Setting the baud rate to a value other that those defined by

> +.B Bnnn
> +constants is possible via

s/via/via the/?

> +.B TCSETS2
> +ioctl, see

s/,/;/

> +.BR ioctl_tty (2).
>   .PP
>   .BR cfgetispeed ()
>   returns the input baud rate stored in the \fItermios\fP structure.
> 


-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

  reply	other threads:[~2021-07-30 18:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 15:30 [PATCH] termios.3: Add information how to set baudrate to any other value Pali Rohár
2021-07-30 18:29 ` Alejandro Colomar (man-pages) [this message]
2021-07-31  1:50   ` G. Branden Robinson
2021-07-31 11:24     ` Alejandro Colomar (man-pages)
2021-07-30 18:45 ` [PATCH v2] termios.3: Add information how to set baud rate " Pali Rohár
2021-07-30 18:59   ` Alejandro Colomar (man-pages)
2021-07-31  0:19   ` G. Branden Robinson
2021-07-31 11:04     ` Alejandro Colomar (man-pages)
2021-07-31 11:06       ` Pali Rohár
2021-08-01 11:07         ` Alejandro Colomar (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8e81fd3-0a7d-8fc8-4d2f-863aec8f6f14@gmail.com \
    --to=alx.manpages@gmail.com \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=pali@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox