From: Alejandro Colomar <alx.manpages@gmail.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: linux-man@vger.kernel.org, Michael Kerrisk <mtk.manpages@gmail.com>
Subject: Re: Garbled text in zic(8) man page
Date: Tue, 22 Nov 2022 20:21:49 +0100 [thread overview]
Message-ID: <dfb539ad-4a72-00a0-c75d-ead317b9ed46@gmail.com> (raw)
In-Reply-To: <CACb0b4=LO+jcwwrirp3iVdu2k0Y8H0PEWwdzs+Jch+D4gJxiog@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 2407 bytes --]
Hi Jonathan,
On 11/22/22 14:13, Jonathan Wakely wrote:
> On Tue, 22 Nov 2022 at 13:00, Jonathan Wakely wrote:
>>
>> On Tue, 22 Nov 2022 at 12:58, Jonathan Wakely wrote:
>>>
>>> Hi,
>>>
>>> The description of the RULES field of a Zone line at:
>>> https://man7.org/linux/man-pages/man8/zic.8.html#FILES
>>> seems garbled:
>>> "giving of the amount of time to be added to local standard time effect"
>>>
>>> It looks like it might be a copy&paste error from the similar text for
>>> the SAVE field of a Rule line. I think the first "of" and the "effect"
>>> should be removed, but I'm not sure if that's correct.
>>
>> This was introduced by
>> https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/man8/zic.8?id=5355e20f816e1e0af93d6bb80439e86f2d1c7be7
>> so maybe it should be reported to tzdb upstream instead.
>
> It's already fixed upstream. The version in the tzdb-2022f package says:
>
> RULES The name of the rules that apply in the timezone or,
> alternatively, a field in the same format as a rule-line SAVE
> column, giving the amount of time to be added to local standard
> time and whether the resulting time is standard or daylight
> saving. If this field is - then standard time always applies.
> When an amount of time is given, only the sum of standard time
> and this amount matters.
>
> So here's a patch for the man page. There are lots of other changes in
> the upstream page though, so another sync might be useful.
As you said, a sync would be better. However, I don't know how Michael did
that. If you know where the page comes from, could you please prepare a patch
that does the sync, and document it in the commit message so that it's easier to
do it in the future?
If you do that, please also sync tzfile(5) and zdump(8) in the commit.
Thanks,
Alex
---
$ cat MAINTAINER_NOTES
Externally generated pages
==========================
A few pages come from external sources. Fixes to the pages should really
go to the upstream source.
tzfile(5), zdump(8), and zic(8) come from the tz project
(https://www.iana.org/time-zones).
bpf-helpers(7) is autogenerated from the kernel sources using scripts.
See man-pages commits 53666f6c3 and 19c7f7839 for details.
--
<http://www.alejandro-colomar.es/>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-11-22 19:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 12:58 Garbled text in zic(8) man page Jonathan Wakely
2022-11-22 13:00 ` Jonathan Wakely
2022-11-22 13:13 ` Jonathan Wakely
2022-11-22 19:21 ` Alejandro Colomar [this message]
2022-11-22 20:31 ` Jonathan Wakely
2022-11-22 20:37 ` Alejandro Colomar
2022-11-22 20:39 ` Jonathan Wakely
2022-11-22 20:41 ` Alejandro Colomar
2022-11-22 21:00 ` Jakub Wilk
2022-11-22 22:33 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfb539ad-4a72-00a0-c75d-ead317b9ed46@gmail.com \
--to=alx.manpages@gmail.com \
--cc=jwakely@redhat.com \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox