Re: [PATCH] man5/tmpfs.5: fix typo in reference to CONFIG_TRANSPARENT_HUGEPAGE

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 2189 bytes --]

Hi John,

On 2023-07-20 10:03, Alejandro Colomar wrote:
> Hi John,
> 
> On 2023-07-19 22:13, John Hubbard wrote:
>> On 7/19/23 12:59, Alejandro Colomar wrote:
>>> On 2023-07-19 04:05, John Hubbard wrote:
>>>> In commit 462a385e9a2 ("tmpfs.5: Document current mount options"), there
>>>> is a reference to CONFIG_TRANSPARENT_HUGE_PAGECACHE. However, that
>>>> option was removed from the kernel via commit 396bcc5299c2 ("mm: remove
>>>> CONFIG_TRANSPARENT_HUGE_PAGECACHE"), a couple of years later.
>>>>
>>>> The net effect is that CONFIG_TRANSPARENT_HUGEPAGE is now used in all
>>>> the remaining places in the kernel where
>>>> CONFIG_TRANSPARENT_HUGE_PAGECACHE had previously been used.
>>>>
>>>> This has caused some minor confusion at the man page level, though. So
>>>> let's fix it by updating the man page to also refer to
>>>> CONFIG_TRANSPARENT_HUGEPAGE.
>>>>
>>>> Reported-by: Vahid Noormofidi <vnoormof@nvidia.com>
>>>> Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
>>>> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>>>> Cc: Andrew Morton <akpm@linux-foundation.org>
>>>> Cc: Carsten Grohmann <carstengrohmann@gmx.de>
>>>> Cc: Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>>>
>>> Accident here :-)
>>>
>>
>> Yes. :)  Michael Kerrisk, could you change that line for me
>> to just be a Cc, for Mike Frysinger?
>>
>> Or, let me know if you'd prefer a re-send of the patch instead.
> 
> I can change it.  Don't worry.  I'll review it later.

Patch applied.  Thanks!
I've slightly reworded the commit message:

-  Use tmpfs.5: instead of man5/tmpfs.5:.  We only specify the last
   filename in the path (see the git log).

-  It really wasn't a typo, because the previous text was written in
   a time when that was the correct spelling.  So, instead, I've
   changed it to talk about an update, rather than a typo fix.

<https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/?id=80e3024bde68ee3fa55cfd87728b81f94ec931df>

Cheers,
Alex

> 
> Thanks,
> Alex
> 
>>
>>
>> thanks,
> 

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]